From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common. Date: Mon, 01 Sep 2014 16:46:41 +0100 Message-ID: <5404B101020000780002F8D7@mail.emea.novell.com> References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de> <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: ian.campbell@citrix.com, tim@xen.org, julien.grall@linaro.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, andres@lagarcavilla.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 01.09.14 at 16:21, wrote: > --- a/xen/arch/x86/x86_64/compat/mm.c > +++ b/xen/arch/x86/x86_64/compat/mm.c > @@ -198,10 +198,6 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > break; > } > > - case XENMEM_access_op: > - rc = mem_access_memop(cmd, guest_handle_cast(arg, xen_mem_access_op_t)); > - break; > - I don't think you can simply drop this. > @@ -967,6 +968,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > } > break; > > + case XEN_DOMCTL_mem_event_op: > + { > + ret = mem_event_domctl(d, &op->u.mem_event_op, > + guest_handle_cast(u_domctl, void)); > + copyback = 1; > + } > + break; Please drop the unnecessary braces. Jan