From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl
 and access_op memop into common.
Date: Tue, 02 Sep 2014 07:30:47 +0100
Message-ID: <54058037020000780002FAC7@mail.emea.novell.com>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de>
	<5404B101020000780002F8D7@mail.emea.novell.com>
	<CAErYnsg4tiuLbb=+eqd7XxT53ZsONhvOTrBdFMy5v0VFtYMtVw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnsg4tiuLbb=+eqd7XxT53ZsONhvOTrBdFMy5v0VFtYMtVw@mail.gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

>>> On 01.09.14 at 18:25, <tamas.lengyel@zentific.com> wrote:
> On Mon, Sep 1, 2014 at 5:46 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
>> >>> On 01.09.14 at 16:21, <tklengyel@sec.in.tum.de> wrote:
>> > --- a/xen/arch/x86/x86_64/compat/mm.c
>> > +++ b/xen/arch/x86/x86_64/compat/mm.c
>> > @@ -198,10 +198,6 @@ int compat_arch_memory_op(unsigned long cmd,
>> XEN_GUEST_HANDLE_PARAM(void) arg)
>> >          break;
>> >      }
>> >
>> > -    case XENMEM_access_op:
>> > -        rc = mem_access_memop(cmd, guest_handle_cast(arg,
>> xen_mem_access_op_t));
>> > -        break;
>> > -
>>
>> I don't think you can simply drop this.
>>
> 
> OK.
> 
> 
>>
>> > @@ -967,6 +968,14 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
>> u_domctl)
>> >      }
>> >      break;
>> >
>> > +    case XEN_DOMCTL_mem_event_op:
>> > +    {
>> > +        ret = mem_event_domctl(d, &op->u.mem_event_op,
>> > +                              guest_handle_cast(u_domctl, void));
>> > +        copyback = 1;
>> > +    }
>> > +    break;
>>
>> Please drop the unnecessary braces.
> 
> All other cases have braces around them here, even when not required, so
> this just follows the established style.

This is so because everyone uses that same argument, blindly
putting braces in place even when they're not needed. As pointed
out recently to someone else (also changing a domctl, istr it was
Aravindh), this breaks indentation of brace-enclosed blocks, so
should be used only when indeed needed.

Jan