From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl
 and access_op memop into common.
Date: Tue, 02 Sep 2014 07:53:00 +0100
Message-ID: <5405856C020000780002FAE4@mail.emea.novell.com>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de>
	<5404B6D9.2020108@linaro.org>
	<CAErYnsh6=dzhKJJiCeGd7XSaGSxoPs1xLkp69awRUQikZN1R2w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnsh6=dzhKJJiCeGd7XSaGSxoPs1xLkp69awRUQikZN1R2w@mail.gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

>>> On 01.09.14 at 22:51, <tamas.lengyel@zentific.com> wrote:
> On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> On 01/09/14 10:21, Tamas K Lengyel wrote:
>> > diff --git a/xen/common/memory.c b/xen/common/memory.c
>> > index cc8a3d0..4e530bf 100644
>> > --- a/xen/common/memory.c
>> > +++ b/xen/common/memory.c
>> > @@ -25,6 +25,7 @@
>> >   #include <asm/hardirq.h>
>> >   #include <asm/p2m.h>
>> >   #include <xen/numa.h>
>> > +#include <xen/mem_access.h>
>> >   #include <public/memory.h>
>>
> 
> @Julien: the problem causing your compile issue is here with the order of
> the inclusion of the headers. public/memory.h needs to be included before
> xen/mem_access.h, I'll fix it in the next iteration..

But then please by making xen/mem_access.h include the prereq
header rather than altering the order here.

Jan