All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v5] ath10k: save firmware debug log messages.
Date: Tue, 02 Sep 2014 07:52:27 -0700	[thread overview]
Message-ID: <5405D9AB.60002@candelatech.com> (raw)
In-Reply-To: <CA+BoTQk2CkmaZtZQ9iQyqU_9K3E_TYwetGNbsKpxYjbUvdL43g@mail.gmail.com>



On 09/02/2014 06:51 AM, Michal Kazior wrote:
> On 2 September 2014 15:38, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> (Dropping linux-wireless)
>>
>> greearb@candelatech.com writes:
>>
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> They may be dumped through the firmware dump debugfs
>>> file.
>>>
>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>
>> Before I start looking at this in detail: this looks fragile and
>> complicated from ath10k point of view. Why not just take a dump of the
>> whole firmware memory and postprocess this, with whatever else we might
>> need from the firmware? That's a lot easier to maintain.
>
> I like the idea although it still makes sense to keep some sort of a
> circular buffer for the debug mesg events delivered via wmi, does it
> not?

Upstream firmware already creates and sends dbglog messages, and it is nice to see
a history.  It sends them to host fairly often, so just grabbing the log
on crash could miss useful info.

For that matter, I'd like to read firmware debuglog ids not just on crash,
which I could easily do with this patch as the basis by creating a new
debugfs file that just dumps the debuglog ids.

I'm not sure what I could do with a full ram dump, but perhaps QCA devs
have something.  It would at a minimum use a lot more RAM to store it.
I just need (know how to decode) the BSS regions, debug-logs, and registers.

Thanks,
Ben

>
>
> Michał
>

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2014-09-02 14:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 15:24 [PATCH v5] ath10k: save firmware debug log messages greearb
2014-08-28 15:24 ` greearb
2014-09-02 13:38 ` Kalle Valo
2014-09-02 13:51   ` Michal Kazior
2014-09-02 14:25     ` Kalle Valo
2014-09-02 16:03       ` Ben Greear
2014-09-02 14:52     ` Ben Greear [this message]
2014-09-02 14:58       ` Li, Yanbo
2014-09-02 15:50         ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5405D9AB.60002@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.