From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v4 00/14] ivshmem: update documentation, add client/server tools Date: Tue, 02 Sep 2014 14:31:08 -0600 Message-ID: <5406290C.3010105@redhat.com> References: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc" Cc: kvm@vger.kernel.org, pbonzini@redhat.com, claudio.fontana@huawei.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca, armbru@redhat.com, stefanha@gmail.com, arei.gonglei@huawei.com To: David Marchand , qemu-devel@nongnu.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754776AbaIBUbV (ORCPT ); Tue, 2 Sep 2014 16:31:21 -0400 In-Reply-To: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/02/2014 09:25 AM, David Marchand wrote: > Here is a patchset containing an update on ivshmem specs documentation = and > importing ivshmem server and client tools. > These tools have been written from scratch and are not related to what = is > available in nahanni repository. > I put them in contrib/ directory as the qemu-doc.texi was already telli= ng the > server was supposed to be there. >=20 > Changes since v3: > - first patch is untouched > - just restored the Reviewed-By Claudio in second patch > - following patches 3-8 take into account Stefan's comments > - patches 9-12 take into account Gonglei's comments > - patch 13 adjusts ivshmem-server default values > - last patch introduces a change in the ivshmem client-server protocol = to > check a protocol version at connect time Rather than introducing new files with bugs, followed by patches to clean it up, why not just introduce the new files correct in the first place? I think you are better off squashing in a lot of the cleanup patches into patch 1. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUBikMAAoJEKeha0olJ0Nq55kIAIUpI3/h2yt3TLe8JLDbSgQz 1RXrREGeTCLk2qXEuDNCZuIB+c9GOCbY09NTLKVcef0KMYTNhtJ+oWrYFShhwaCv TC/pvPA1lNNvmOO5VWba8Fpe+UKnK0XeVneJjd2GDaz4X0XvzbS+k8qCv5wuYtrg HlF2hdi1eZ7MxFQDUW2jnwh9TyyYImraeyPcwfBJS3TfC1REKsXKeMafFKIUSzMH Zq5ORD/kbLtv5l7l3HO0Rp+Gri+Y6VlUx+wNCsn7ggGwnqNHLM5ccpRqzM9Ht84G CoB3sXsiwfvfE8g83ZdTpecpO3LWzJzIUvPLMVb3if3+0omEf7yhAeQclThKGtc= =0cdv -----END PGP SIGNATURE----- --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOuje-00009A-Nk for qemu-devel@nongnu.org; Tue, 02 Sep 2014 16:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOujZ-0006z4-BS for qemu-devel@nongnu.org; Tue, 02 Sep 2014 16:31:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOujZ-0006yv-40 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 16:31:21 -0400 Message-ID: <5406290C.3010105@redhat.com> Date: Tue, 02 Sep 2014 14:31:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc" Subject: Re: [Qemu-devel] [PATCH v4 00/14] ivshmem: update documentation, add client/server tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Marchand , qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, stefanha@gmail.com, claudio.fontana@huawei.com, armbru@redhat.com, arei.gonglei@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/02/2014 09:25 AM, David Marchand wrote: > Here is a patchset containing an update on ivshmem specs documentation = and > importing ivshmem server and client tools. > These tools have been written from scratch and are not related to what = is > available in nahanni repository. > I put them in contrib/ directory as the qemu-doc.texi was already telli= ng the > server was supposed to be there. >=20 > Changes since v3: > - first patch is untouched > - just restored the Reviewed-By Claudio in second patch > - following patches 3-8 take into account Stefan's comments > - patches 9-12 take into account Gonglei's comments > - patch 13 adjusts ivshmem-server default values > - last patch introduces a change in the ivshmem client-server protocol = to > check a protocol version at connect time Rather than introducing new files with bugs, followed by patches to clean it up, why not just introduce the new files correct in the first place? I think you are better off squashing in a lot of the cleanup patches into patch 1. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUBikMAAoJEKeha0olJ0Nq55kIAIUpI3/h2yt3TLe8JLDbSgQz 1RXrREGeTCLk2qXEuDNCZuIB+c9GOCbY09NTLKVcef0KMYTNhtJ+oWrYFShhwaCv TC/pvPA1lNNvmOO5VWba8Fpe+UKnK0XeVneJjd2GDaz4X0XvzbS+k8qCv5wuYtrg HlF2hdi1eZ7MxFQDUW2jnwh9TyyYImraeyPcwfBJS3TfC1REKsXKeMafFKIUSzMH Zq5ORD/kbLtv5l7l3HO0Rp+Gri+Y6VlUx+wNCsn7ggGwnqNHLM5ccpRqzM9Ht84G CoB3sXsiwfvfE8g83ZdTpecpO3LWzJzIUvPLMVb3if3+0omEf7yhAeQclThKGtc= =0cdv -----END PGP SIGNATURE----- --VOFcPtf8xBagcFKpGJvs9PrDuPvkUjRQc--