All of lore.kernel.org
 help / color / mirror / Atom feed
From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
To: Ian Morris <ipm@chirality.org.uk>, netdev@vger.kernel.org
Cc: hideaki.yoshifuji@miraclelinux.com,
	YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next 1/4] ipv6: coding style - no assignment in if statements
Date: Wed, 03 Sep 2014 10:44:09 +0900	[thread overview]
Message-ID: <54067269.9070200@miraclelinux.com> (raw)
In-Reply-To: <1409685364-4327-2-git-send-email-ipm@chirality.org.uk>

Hi,

Ian Morris wrote:
> This patch makes no changes to the logic of the ipv6 stack however
> it addresses some coding style issues by removing assignments made
> in if statements.
> 
> No change in the object output is detected by the objdiff script.
> 
> Signed-off-by: Ian Morris <ipm@chirality.org.uk>

> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index b7a3e7b..86fc687 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -754,9 +754,8 @@ slow_path:
>   		/*
>   		 *	Allocate buffer.
>   		 */
> -
> -		if ((frag = alloc_skb(len + hlen + sizeof(struct frag_hdr) +
> -				      hroom + troom, GFP_ATOMIC)) == NULL) {
> +		frag = alloc_skb(len + hlen + sizeof(struct frag_hdr) + hroom + troom, GFP_ATOMIC);
> +		if (frag == NULL) {

This line is too long.
Otherwise, it seems okay.

-- 
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION

  reply	other threads:[~2014-09-03  1:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 19:16 [PATCH net-next 0/4] ipv6: coding style improvements Ian Morris
2014-09-02 19:16 ` [PATCH net-next 1/4] ipv6: coding style - no assignment in if statements Ian Morris
2014-09-03  1:44   ` YOSHIFUJI Hideaki [this message]
2014-09-02 19:16 ` [PATCH net-next 2/4] ipv6: coding style - min to min_t conversion Ian Morris
2014-09-03  1:29   ` YOSHIFUJI Hideaki
2014-09-02 19:16 ` [PATCH net-next 3/4] ipv6: coding style - convert printk Ian Morris
2014-09-03  1:44   ` YOSHIFUJI Hideaki
2014-09-02 19:16 ` [PATCH net-next 4/4] ipv6: coding style - cleanse bracing Ian Morris
2014-09-03  1:31   ` YOSHIFUJI Hideaki/吉藤英明
2014-09-03  7:52     ` Yuval Mintz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54067269.9070200@miraclelinux.com \
    --to=hideaki.yoshifuji@miraclelinux.com \
    --cc=ipm@chirality.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.