From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH 2/5] xen: Optimize introspection access to guest state Date: Wed, 03 Sep 2014 14:11:43 +0300 Message-ID: <5406F76F.2090300@bitdefender.com> References: <1409730301-13155-1-git-send-email-rcojocaru@bitdefender.com> <1409730301-13155-2-git-send-email-rcojocaru@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XP8Th-0002jw-4e for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 11:11:53 +0000 In-Reply-To: <1409730301-13155-2-git-send-email-rcojocaru@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/03/2014 10:44 AM, Razvan Cojocaru wrote: > Speed optimization for introspection purposes: a handful of registers > are sent along with each mem_event. This requires enlargement of the > mem_event_request / mem_event_response stuctures, and additional code > to fill in relevant values. Since the EPT event processing code needs > more data than CR3 or MSR event processors, hvm_mem_event_fill_regs() > fills in less data than p2m_mem_event_fill_regs(), in order to avoid > overhead. Struct hvm_hw_cpu has been considered instead of the custom > struct mem_event_regs_st, but its size would cause quick filling up > of the mem_event ring buffer. > > Signed-off-by: Razvan Cojocaru > Acked-by: Jan Beulich > --- > tools/libxc/xc_mem_access.c | 10 +++++++++- > tools/libxc/xc_mem_event.c | 7 +++++-- > tools/libxc/xc_private.h | 2 +- > tools/libxc/xenctrl.h | 2 ++ > xen/arch/x86/hvm/vmx/vmcs.c | 25 +++++++++++++++++++++++++ > xen/arch/x86/hvm/vmx/vmx.c | 13 +++++++++++++ > xen/arch/x86/mm/mem_event.c | 11 +++++++++++ > xen/include/asm-x86/hvm/domain.h | 1 + > xen/include/asm-x86/hvm/hvm.h | 2 ++ > xen/include/asm-x86/hvm/vmx/vmcs.h | 7 +++++++ > xen/include/public/domctl.h | 7 ++++--- > 11 files changed, 80 insertions(+), 7 deletions(-) Sorry, I've managed to switch the description of patches 2 and 3. I'll send V2 shortly with the correction. Thanks, Razvan Cojocaru