From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v03 08/10] arm: add trap for remoteproc mmio
 accesses
Date: Wed, 03 Sep 2014 10:52:06 +0100
Message-ID: <540700E60200007800030251@mail.emea.novell.com>
References: <1409672770-23164-1-git-send-email-andrii.tseglytskyi@globallogic.com>
	<1409672770-23164-9-git-send-email-andrii.tseglytskyi@globallogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409672770-23164-9-git-send-email-andrii.tseglytskyi@globallogic.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>
Cc: Julien Grall <julien.grall@linaro.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 02.09.14 at 17:46, <andrii.tseglytskyi@globallogic.com> wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -35,6 +35,7 @@
>  #include <asm/debugger.h>
>  #include <asm/p2m.h>
>  #include <asm/processor.h>
> +#include <asm/remoteproc_iommu.h>

And this doesn't break the build on x86? I think the entire change
ought to go into arch_domain_create().

> @@ -376,6 +377,12 @@ struct domain *domain_create(
>          spin_unlock(&domlist_update_lock);
>      }
>  
> +#ifdef HAS_REMOTEPROC
> +    if ( remoteproc_iommu_register_mmio_handlers(d) )
> +        printk("Failed to register remoteprocessor mmu mmio handlers for domain %d\n",
> +               d->domain_id);
> +#endif

Such guest related printk()-s ought to be log-leveled. Plus with
an isolated change like this it remains entirely unclear whether
just logging a message here is the right kind of error handling.

Jan