From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic Date: Wed, 03 Sep 2014 14:57:40 +0300 Message-ID: <54070234.30201@mm-sol.com> References: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:42606 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbaICL52 (ORCPT ); Wed, 3 Sep 2014 07:57:28 -0400 In-Reply-To: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , Chris Ball , Ulf Hansson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Asutosh Das , Venkat Gopalakrishnan On 09/03/2014 02:58 AM, Stephen Boyd wrote: > If we're tuning on a big-endian CPU we'll never determine we properly > tuned the device because we compare the data we received from the > controller with a table that assumes the CPU is little-endian. > Change the table to be an array of bytes instead of 32-bit words > so we can use memcmp() without needing to byte-swap every word > depending on the endianess of the CPU. > > Cc: Asutosh Das > Cc: Venkat Gopalakrishnan > Cc: Georgi Djakov > Fixes: 415b5a75da43 "mmc: sdhci-msm: Add platform_execute_tuning implementation" > Signed-off-by: Stephen Boyd > --- Looks nice. Thanks! Reviewed-by: Georgi Djakov From mboxrd@z Thu Jan 1 00:00:00 1970 From: gdjakov@mm-sol.com (Georgi Djakov) Date: Wed, 03 Sep 2014 14:57:40 +0300 Subject: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic In-Reply-To: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org> References: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org> Message-ID: <54070234.30201@mm-sol.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/03/2014 02:58 AM, Stephen Boyd wrote: > If we're tuning on a big-endian CPU we'll never determine we properly > tuned the device because we compare the data we received from the > controller with a table that assumes the CPU is little-endian. > Change the table to be an array of bytes instead of 32-bit words > so we can use memcmp() without needing to byte-swap every word > depending on the endianess of the CPU. > > Cc: Asutosh Das > Cc: Venkat Gopalakrishnan > Cc: Georgi Djakov > Fixes: 415b5a75da43 "mmc: sdhci-msm: Add platform_execute_tuning implementation" > Signed-off-by: Stephen Boyd > --- Looks nice. Thanks! Reviewed-by: Georgi Djakov