From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/NMI: allow passing just "watchdog" again
Date: Wed, 3 Sep 2014 13:32:02 +0100
Message-ID: <54070A42.4070001@citrix.com>
References: <1409156728-4995-1-git-send-email-ross.lagerwall@citrix.com>
	<53FF379C.8070701@citrix.com> <54047450.2080004@citrix.com>
	<5404A3FC020000780002F835@mail.emea.novell.com>
	<54072487020000780003042F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1XP9jL-00013V-1A
	for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 12:32:07 +0000
In-Reply-To: <54072487020000780003042F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 03/09/14 13:24, Jan Beulich wrote:
> This capability got inadvertently lost in commit 3ea2ba980a ("x86/NMI:
> allow processing unknown NMIs when watchdog is enabled") due to an
> oversight of mine.
>
> Reported-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/nmi.c
> +++ b/xen/arch/x86/nmi.c
> @@ -49,6 +49,12 @@ bool_t watchdog_force = 0;
>  
>  static void __init parse_watchdog(char *s)
>  {
> +    if ( !*s )
> +    {
> +        opt_watchdog = 1;
> +        return;
> +    }
> +
>      switch ( parse_bool(s) )
>      {
>      case 0:
>
>
>