From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Ye <wei.ye@intel.com>
Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, tim@xen.org,
ian.jackson@eu.citrix.com, donald.d.dugger@intel.com,
xen-devel@lists.xen.org, Paul.Durrant@citrix.com,
zhiyuan.lv@intel.com, yang.z.zhang@intel.com
Subject: Re: [PATCH v3 2/2] ioreq-server: write protected range and forwarding
Date: Wed, 03 Sep 2014 14:17:04 +0100 [thread overview]
Message-ID: <540730F0020000780003055A@mail.emea.novell.com> (raw)
In-Reply-To: <1409781199-12052-3-git-send-email-wei.ye@intel.com>
>>> On 03.09.14 at 23:53, <wei.ye@intel.com> wrote:
> +static int hvm_change_p2m_type_ioreq_server(struct domain *d, uint16_t set,
> + uint64_t start, uint64_t end)
> +{
> + int rc = -EINVAL;
> + uint64_t gpfn_s, gpfn_e, gpfn;
> + p2m_type_t ot, nt;
> +
> + if ( set )
> + {
> + ot = p2m_ram_rw;
> + nt = p2m_mmio_write_dm;
> + }
> + else
> + {
> + ot = p2m_mmio_write_dm;
> + nt = p2m_ram_rw;
> + }
> +
> + gpfn_s = start >> PAGE_SHIFT;
> + gpfn_e = end >> PAGE_SHIFT;
Considering that the first really ought to be PFN_DOWN() - is the latter
really correct? I'd rather expect that to be PFN_UP()...
> --- a/xen/include/asm-x86/hvm/domain.h
> +++ b/xen/include/asm-x86/hvm/domain.h
> @@ -48,7 +48,7 @@ struct hvm_ioreq_vcpu {
> evtchn_port_t ioreq_evtchn;
> };
>
> -#define NR_IO_RANGE_TYPES (HVMOP_IO_RANGE_PCI + 1)
> +#define NR_IO_RANGE_TYPES (HVMOP_IO_RANGE_WP + 1)
> #define MAX_NR_IO_RANGES 256
So in the end you didn't even find it necessary to bump the limit
on the number of ranges per domain? Iirc that was your major
objection against using existing infrastructure.
Jan
next prev parent reply other threads:[~2014-09-03 13:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 21:53 [PATCH v3 0/2] Extend ioreq-server to support page write protection Wei Ye
2014-09-03 21:53 ` [PATCH v3 1/2] x86: add p2m_mmio_write_dm Wei Ye
2014-09-03 9:54 ` Paul Durrant
2014-09-03 10:03 ` Jan Beulich
2014-09-03 21:53 ` [PATCH v3 2/2] ioreq-server: write protected range and forwarding Wei Ye
2014-09-03 10:11 ` Paul Durrant
2014-09-04 23:10 ` Tian, Kevin
2014-09-05 0:44 ` Ye, Wei
2014-09-05 9:01 ` Paul Durrant
2014-09-10 6:10 ` Ye, Wei
2014-09-10 21:02 ` Tian, Kevin
2014-09-11 14:38 ` Paul Durrant
2014-09-16 21:25 ` Tian, Kevin
2014-09-11 14:45 ` Paul Durrant
2014-09-03 13:17 ` Jan Beulich [this message]
2014-09-04 0:31 ` Ye, Wei
2014-09-10 5:32 ` Ye, Wei
2014-09-10 9:19 ` Jan Beulich
2014-09-10 9:30 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540730F0020000780003055A@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=donald.d.dugger@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.ye@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.