From: "Michel Dänzer" <michel@daenzer.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
linuxppc-dev@ozlabs.org, "Michel Dänzer" <michel.daenzer@amd.com>,
"Christian Koenig" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: TTM placement & caching issue/questions
Date: Thu, 04 Sep 2014 16:59:58 +0900 [thread overview]
Message-ID: <54081BFE.6020509@daenzer.net> (raw)
In-Reply-To: <54081BC5.8000703@daenzer.net>
On 04.09.2014 16:59, Michel Dänzer wrote:
> On 04.09.2014 16:54, Benjamin Herrenschmidt wrote:
>> On Thu, 2014-09-04 at 16:19 +0900, Michel Dänzer wrote:
>>>> +#else /* CONFIG_X86 */
>>>> +int ttm_tt_set_placement_caching(struct ttm_tt *ttm, uint32_t
>>> *placement)
>>>> +{
>>>> + if (*placement & (TTM_PL_TT | TTM_PL_FLAG_SYSTEM)) {
>>>> + ttm->caching_state = tt_cached;
>>>> + *placement &= ~TTM_PL_MASK_CACHING;
>>>> + *placement |= TTM_PL_FLAG_CACHED;
>>>
>>> NAK, this will break AGP on PowerMacs.
>>
>> ... which doesn't work reliably anyway with DRI2 :-)
>
> Define 'not reliably'. I have uptimes of weeks, and I'm pretty sure I'm
> not alone, at least with AGP 1x it seems to work quite well for most
> people. So I don't see the justification for intentionally breaking it
> completely for all of us.
Even more so because PCI GART is unusably slow in general.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2014-09-04 8:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 0:12 TTM placement & caching issue/questions Benjamin Herrenschmidt
2014-09-04 0:12 ` Benjamin Herrenschmidt
2014-09-04 1:55 ` Jerome Glisse
2014-09-04 2:07 ` Jerome Glisse
2014-09-04 2:07 ` Jerome Glisse
2014-09-04 2:25 ` Benjamin Herrenschmidt
2014-09-04 2:25 ` Benjamin Herrenschmidt
2014-09-04 2:31 ` Jerome Glisse
2014-09-04 2:31 ` Jerome Glisse
2014-09-04 2:32 ` Jerome Glisse
2014-09-04 2:32 ` Jerome Glisse
2014-09-04 2:36 ` Jerome Glisse
2014-09-04 2:36 ` Jerome Glisse
2014-09-04 5:23 ` Benjamin Herrenschmidt
2014-09-04 6:45 ` Gabriel Paubert
2014-09-04 7:19 ` Michel Dänzer
2014-09-04 7:54 ` Benjamin Herrenschmidt
2014-09-04 7:59 ` Michel Dänzer
2014-09-04 7:59 ` Michel Dänzer [this message]
2014-09-04 8:07 ` Benjamin Herrenschmidt
2014-09-04 2:15 ` Benjamin Herrenschmidt
2014-09-04 7:12 ` Michel Dänzer
2014-09-04 7:44 ` Thomas Hellstrom
2014-09-04 7:44 ` Thomas Hellstrom
2014-09-04 8:06 ` Benjamin Herrenschmidt
2014-09-04 8:46 ` Thomas Hellstrom
2014-09-04 8:46 ` Thomas Hellstrom
2014-09-04 9:34 ` Daniel Vetter
2014-09-04 9:34 ` Daniel Vetter
2014-09-04 9:43 ` Benjamin Herrenschmidt
2014-09-04 10:23 ` Thomas Hellstrom
2014-09-04 10:23 ` Thomas Hellstrom
[not found] <ED4D93630842CD4385F644DC5158EE9171B05E72@NTOVMAIL03.ad.otto.de>
2014-09-05 7:40 ` Jochen Rollwagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54081BFE.6020509@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=benh@kernel.crashing.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michel.daenzer@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.