From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <540993B3.1000701@cogentembedded.com> Date: Fri, 05 Sep 2014 14:42:59 +0400 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org Message-ID: <20140905104259.c7eRiYryI2xWQ4YSvBMnT-qVUxkSYpFAu5OVxhYwwCA@z> List-Archive: List-Post: To: Yijing Wang , Bjorn Helgaas Cc: Xinwei Hu , Wuyun , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle List-ID: Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 05 Sep 2014 14:42:59 +0400 Message-ID: <540993B3.1000701@cogentembedded.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Yijing Wang , Bjorn Helgaas Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, arnab.basu-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Xinwei Hu , Tony Luck , Ralf Baechle , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Wuyun , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "David S. Miller" List-Id: linux-arch.vger.kernel.org Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 05 Sep 2014 10:42:59 +0000 Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <540993B3.1000701@cogentembedded.com> List-Id: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yijing Wang , Bjorn Helgaas Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, arnab.basu-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Xinwei Hu , Tony Luck , Ralf Baechle , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Wuyun , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "David S. Miller" Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com [209.85.217.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 593A61A054D for ; Fri, 5 Sep 2014 20:43:05 +1000 (EST) Received: by mail-lb0-f179.google.com with SMTP id p9so714474lbv.24 for ; Fri, 05 Sep 2014 03:43:01 -0700 (PDT) Message-ID: <540993B3.1000701@cogentembedded.com> Date: Fri, 05 Sep 2014 14:42:59 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Yijing Wang , Bjorn Helgaas Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Xinwei Hu , Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 05 Sep 2014 14:42:59 +0400 Subject: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing@huawei.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> Message-ID: <540993B3.1000701@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 05 Sep 2014 10:42:59 +0000 Subject: Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <540993B3.1000701@cogentembedded.com> List-Id: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-10-git-send-email-wangyijing@huawei.com> In-Reply-To: <1409911806-10519-10-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yijing Wang , Bjorn Helgaas Cc: Xinwei Hu , Wuyun , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > Signed-off-by: Yijing Wang > --- > drivers/iommu/irq_remapping.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 33c4395..e75026e 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c [...] > @@ -165,9 +170,10 @@ static void __init irq_remapping_modify_x86_ops(void) > x86_io_apic_ops.set_affinity = set_remapped_irq_affinity; > x86_io_apic_ops.setup_entry = setup_ioapic_remapped_entry; > x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped; > - x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; > + x86_msi.setup_msi_irqs = irq_remapping_setup_msi_irqs; AFAICS, this change only converts tabs to spaces, so not needed at all. > x86_msi.setup_hpet_msi = setup_hpet_msi_remapped; > x86_msi.compose_msi_msg = compose_remapped_msi_msg; > + x86_msi_chip = &remap_msi_chip; Please align = with the rest of assignments. WBR, Sergei