From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCCDC4332F for ; Thu, 16 Sep 2021 16:15:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D8DD61462 for ; Thu, 16 Sep 2021 16:15:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D8DD61462 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C11B06EE28; Thu, 16 Sep 2021 16:15:36 +0000 (UTC) Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B98F6EE29 for ; Thu, 16 Sep 2021 16:15:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631808935; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=VopVy3p4TBJI0nA0siqV1XpbK3ZcX0Kn9uhei4SlZuU=; b=egNTKZ9yHhgUuvlUfNpAX4M174WQWS4FQwzkdmeKNrzimksqwHEj5lNC9KUYoVCH2QIMgBn8 GMfoo2Ah1HygctLMOW5ZL2ZsuPjHdqHC7NpBxQpje4Vkn5Q9X8ez8JCH/VIVrt+h4a082Mu7 og1HpztMI+sZWf62YIpEbRLOWgk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 61436d98bd6681d8ed92e170 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 16:15:20 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D0885C4361B; Thu, 16 Sep 2021 16:15:19 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6CE32C4360D; Thu, 16 Sep 2021 16:15:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Sep 2021 09:15:16 -0700 From: abhinavk@codeaurora.org To: Fabio Estevam Cc: Rob Clark , DRI mailing list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Dmitry Baryshkov , stable Subject: Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices In-Reply-To: References: <20210914174831.2044420-1-festevam@gmail.com> <96038e06b1141ad3348611a25544356e@codeaurora.org> Message-ID: <5409ccef7ee4359d070eed3acd955590@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Fabio Thanks for confirming. Although I have no issues with your change, I am curious why even msm is probing and/or binding. Your device tree should not be having any mdp/dpu nodes then. Thanks Abhinav On 2021-09-16 04:42, Fabio Estevam wrote: > Hi Abhinav, > > On Wed, Sep 15, 2021 at 11:22 PM wrote: > >> Are you not using DPU or are you not using mdp4/mdp5 as well? Even if >> you are using any of mdps, kms should >> not be NULL. Hence wanted to check the test case. > > I am running i.MX53, which is an NXP SoC, not Qualcomm's. > > It does not use DPU, nor MDP4/5 and kms is NULL in this case. > > Some debug prints to confirm: > > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -557,18 +557,22 @@ static int msm_drm_init(struct device *dev, > const struct drm_driver *drv) > case KMS_MDP4: > kms = mdp4_kms_init(ddev); > priv->kms = kms; > + pr_err("******** KMS_MDP4\n"); > break; > case KMS_MDP5: > kms = mdp5_kms_init(ddev); > + pr_err("******** KMS_MDP5\n"); > break; > case KMS_DPU: > kms = dpu_kms_init(ddev); > + pr_err("******** KMS_DPU\n"); > priv->kms = kms; > break; > default: > /* valid only for the dummy headless case, where > of_node=NULL */ > WARN_ON(dev->of_node); > kms = NULL; > + pr_err("******** KMS is NULL\n"); > break; > } > > # dmesg | grep KMS > [ 3.153215] ******** KMS is NULL From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2B6C433EF for ; Thu, 16 Sep 2021 16:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB46E615E0 for ; Thu, 16 Sep 2021 16:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240554AbhIPQTA (ORCPT ); Thu, 16 Sep 2021 12:19:00 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:25226 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235212AbhIPQQ7 (ORCPT ); Thu, 16 Sep 2021 12:16:59 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631808938; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=VopVy3p4TBJI0nA0siqV1XpbK3ZcX0Kn9uhei4SlZuU=; b=MGPO4y4z2tuKOkTurm5uwECMaOXSavOhnb+xbz9jqzQQ6fqFRvmYofyozg4OLzOWbjkprjCd 6/kwxsBJe8qrwIj5K4NCmEsj7qrVwNIY0TzBjxDCUKYtDbXkHuTGACNSGHW3uBjCAPNS/23+ M4RkT8OpKZipXZemdFVwQiD1wAk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1ZjI4MyIsICJzdGFibGVAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 61436d99d914b05182b04da7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Sep 2021 16:15:21 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 028B2C43639; Thu, 16 Sep 2021 16:15:19 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6CE32C4360D; Thu, 16 Sep 2021 16:15:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Sep 2021 09:15:16 -0700 From: abhinavk@codeaurora.org To: Fabio Estevam Cc: Rob Clark , DRI mailing list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Dmitry Baryshkov , stable Subject: Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices In-Reply-To: References: <20210914174831.2044420-1-festevam@gmail.com> <96038e06b1141ad3348611a25544356e@codeaurora.org> Message-ID: <5409ccef7ee4359d070eed3acd955590@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Fabio Thanks for confirming. Although I have no issues with your change, I am curious why even msm is probing and/or binding. Your device tree should not be having any mdp/dpu nodes then. Thanks Abhinav On 2021-09-16 04:42, Fabio Estevam wrote: > Hi Abhinav, > > On Wed, Sep 15, 2021 at 11:22 PM wrote: > >> Are you not using DPU or are you not using mdp4/mdp5 as well? Even if >> you are using any of mdps, kms should >> not be NULL. Hence wanted to check the test case. > > I am running i.MX53, which is an NXP SoC, not Qualcomm's. > > It does not use DPU, nor MDP4/5 and kms is NULL in this case. > > Some debug prints to confirm: > > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -557,18 +557,22 @@ static int msm_drm_init(struct device *dev, > const struct drm_driver *drv) > case KMS_MDP4: > kms = mdp4_kms_init(ddev); > priv->kms = kms; > + pr_err("******** KMS_MDP4\n"); > break; > case KMS_MDP5: > kms = mdp5_kms_init(ddev); > + pr_err("******** KMS_MDP5\n"); > break; > case KMS_DPU: > kms = dpu_kms_init(ddev); > + pr_err("******** KMS_DPU\n"); > priv->kms = kms; > break; > default: > /* valid only for the dummy headless case, where > of_node=NULL */ > WARN_ON(dev->of_node); > kms = NULL; > + pr_err("******** KMS is NULL\n"); > break; > } > > # dmesg | grep KMS > [ 3.153215] ******** KMS is NULL