From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPzYP-00039X-Bt for qemu-devel@nongnu.org; Fri, 05 Sep 2014 15:52:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPzYI-0006Lg-Ig for qemu-devel@nongnu.org; Fri, 05 Sep 2014 15:52:17 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:47892 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPzYI-0006LU-8h for qemu-devel@nongnu.org; Fri, 05 Sep 2014 15:52:10 -0400 Message-ID: <540A1464.2060003@kamp.de> Date: Fri, 05 Sep 2014 21:52:04 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1409935888-18552-1-git-send-email-pl@kamp.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] introduce max_transfer_length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: Kevin Wolf , Paolo Bonzini , qemu-devel , Stefan Hajnoczi , Max Reitz Am 05.09.2014 um 19:05 schrieb ronnie sahlberg: > Looks good to me. > > (minor question is just why not let default max be 0xffff for both 10 > and 16 CDBs ?) You are right. I was looking at the technical limit, but in fact it doesn't make sense to have different limits. Its ridiculous to say, you wan't to do big I/O then you need a target thats bigger than 2TB ;-) Peter > > On Fri, Sep 5, 2014 at 9:51 AM, Peter Lieven wrote: >> This series adds the basics for introducing a maximum transfer length >> to the block layer. Its main purpose is currently avoiding that >> a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. >> This is a required bug fix. >> >> Discussed reporting of this maximum in the SCSI Disk Inquiry Emulation >> of the Block Limits VPD is currently not added as we do not import any >> of the other limits there. This has to be addresses in a seperate series. >> >> Peter Lieven (4): >> BlockLimits: introduce max_transfer_length >> block: immediate cancel oversized read/write requests >> block/iscsi: set max_transfer_length >> block: avoid creating oversized writes in multiwrite_merge >> >> block.c | 23 +++++++++++++++++++++++ >> block/iscsi.c | 12 ++++++++++-- >> include/block/block_int.h | 3 +++ >> 3 files changed, 36 insertions(+), 2 deletions(-) >> >> -- >> 1.7.9.5 >>