From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQxIP-0005rI-EO for qemu-devel@nongnu.org; Mon, 08 Sep 2014 07:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQxIJ-00081m-0R for qemu-devel@nongnu.org; Mon, 08 Sep 2014 07:39:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34859 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQxII-00081g-Pf for qemu-devel@nongnu.org; Mon, 08 Sep 2014 07:39:38 -0400 Message-ID: <540D9579.9060803@suse.de> Date: Mon, 08 Sep 2014 13:39:37 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1410154231-19828-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1410154231-19828-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: Cleanup machine naming conventions, and prepare for 2.2 release List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org On 08.09.14 07:30, David Gibson wrote: > As of qemu-2.1, spapr/pseries, has a set of versioned machine classes to > represent the machine type as it appeared to the guest in different qemu > versions. This allows for safe migration of guests between current and > future qemu versions. > > However, these are organized a bit differently from those for PC: on PC, > the default plain "pc" machine type is just an alias for the most recent > versioned machine type. In sPAPR, it names the base machine class from > which the versioned types are derived. > > The PC approach is preferable; it makes it clearer which explicit version > is the current one. Additionally updating the "current" machine as the > base class makes it even more likely than otherwise to incorrectly alter > the versioned machines' behaviour when updating the current machine. > > Therefore this patch changes sPAPR to the PC approach - the base class > becomes abstract, and plain "pseries" becomes an alias for the most > recent versioned machine class. Since qemu-2.1 is now released, we also > create a new pseries-2.2 machine type, to incorporate changes during this > development cycle (for now it is identical to pseries-2.1). > > Signed-off-by: David Gibson Thanks, applied to ppc-next. Alex