All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/efi: Directly include needed headers
@ 2014-09-08 13:22 Daniel Kiper
  2014-09-08 17:35 ` David Vrabel
  2014-09-08 17:35 ` [Xen-devel] " David Vrabel
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Kiper @ 2014-09-08 13:22 UTC (permalink / raw)
  To: linux-kernel, x86, xen-devel
  Cc: boris.ostrovsky, david.vrabel, hpa, konrad.wilk, mingo, tglx,
	Daniel Kiper

I discovered that some needed stuff is defined/declared in headers
which are not included directly. Currently it works but if somebody
remove required headers from currently included headers then build
will break. So, just in case directly include all needed headers.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 arch/x86/xen/efi.c |    2 ++
 drivers/xen/efi.c  |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c
index a02e09e..be14cc3 100644
--- a/arch/x86/xen/efi.c
+++ b/arch/x86/xen/efi.c
@@ -15,12 +15,14 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <linux/bitops.h>
 #include <linux/efi.h>
 #include <linux/init.h>
 #include <linux/string.h>
 
 #include <xen/xen-ops.h>
 
+#include <asm/page.h>
 #include <asm/setup.h>
 
 void __init xen_efi_init(void)
diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index 31f618a..1f850c9 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -27,6 +27,8 @@
 #include <xen/interface/platform.h>
 #include <xen/xen.h>
 
+#include <asm/page.h>
+
 #include <asm/xen/hypercall.h>
 
 #define INIT_EFI_OP(name) \
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Xen-devel] [PATCH] xen/efi: Directly include needed headers
  2014-09-08 13:22 [PATCH] xen/efi: Directly include needed headers Daniel Kiper
  2014-09-08 17:35 ` David Vrabel
@ 2014-09-08 17:35 ` David Vrabel
  2014-09-09 11:28   ` Daniel Kiper
  2014-09-09 11:28   ` [Xen-devel] " Daniel Kiper
  1 sibling, 2 replies; 6+ messages in thread
From: David Vrabel @ 2014-09-08 17:35 UTC (permalink / raw)
  To: Daniel Kiper, linux-kernel, x86, xen-devel
  Cc: mingo, david.vrabel, hpa, boris.ostrovsky, tglx

On 08/09/14 14:22, Daniel Kiper wrote:
> I discovered that some needed stuff is defined/declared in headers
> which are not included directly. Currently it works but if somebody
> remove required headers from currently included headers then build
> will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xen/efi: Directly include needed headers
  2014-09-08 13:22 [PATCH] xen/efi: Directly include needed headers Daniel Kiper
@ 2014-09-08 17:35 ` David Vrabel
  2014-09-08 17:35 ` [Xen-devel] " David Vrabel
  1 sibling, 0 replies; 6+ messages in thread
From: David Vrabel @ 2014-09-08 17:35 UTC (permalink / raw)
  To: Daniel Kiper, linux-kernel, x86, xen-devel
  Cc: boris.ostrovsky, mingo, tglx, david.vrabel, hpa

On 08/09/14 14:22, Daniel Kiper wrote:
> I discovered that some needed stuff is defined/declared in headers
> which are not included directly. Currently it works but if somebody
> remove required headers from currently included headers then build
> will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Xen-devel] [PATCH] xen/efi: Directly include needed headers
  2014-09-08 17:35 ` [Xen-devel] " David Vrabel
  2014-09-09 11:28   ` Daniel Kiper
@ 2014-09-09 11:28   ` Daniel Kiper
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2014-09-09 11:28 UTC (permalink / raw)
  To: David Vrabel
  Cc: linux-kernel, x86, xen-devel, mingo, hpa, boris.ostrovsky, tglx

On Mon, Sep 08, 2014 at 06:35:44PM +0100, David Vrabel wrote:
> On 08/09/14 14:22, Daniel Kiper wrote:
> > I discovered that some needed stuff is defined/declared in headers
> > which are not included directly. Currently it works but if somebody
> > remove required headers from currently included headers then build
> > will break. So, just in case directly include all needed headers.
>
> Seems rather pointless, but harmless.
>
> Applied to devel/for-linus-3.18

Thanks.

Daniel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xen/efi: Directly include needed headers
  2014-09-08 17:35 ` [Xen-devel] " David Vrabel
@ 2014-09-09 11:28   ` Daniel Kiper
  2014-09-09 11:28   ` [Xen-devel] " Daniel Kiper
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2014-09-09 11:28 UTC (permalink / raw)
  To: David Vrabel
  Cc: x86, linux-kernel, mingo, hpa, xen-devel, boris.ostrovsky, tglx

On Mon, Sep 08, 2014 at 06:35:44PM +0100, David Vrabel wrote:
> On 08/09/14 14:22, Daniel Kiper wrote:
> > I discovered that some needed stuff is defined/declared in headers
> > which are not included directly. Currently it works but if somebody
> > remove required headers from currently included headers then build
> > will break. So, just in case directly include all needed headers.
>
> Seems rather pointless, but harmless.
>
> Applied to devel/for-linus-3.18

Thanks.

Daniel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] xen/efi: Directly include needed headers
@ 2014-09-08 13:22 Daniel Kiper
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2014-09-08 13:22 UTC (permalink / raw)
  To: linux-kernel, x86, xen-devel
  Cc: Daniel Kiper, mingo, david.vrabel, hpa, boris.ostrovsky, tglx

I discovered that some needed stuff is defined/declared in headers
which are not included directly. Currently it works but if somebody
remove required headers from currently included headers then build
will break. So, just in case directly include all needed headers.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 arch/x86/xen/efi.c |    2 ++
 drivers/xen/efi.c  |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c
index a02e09e..be14cc3 100644
--- a/arch/x86/xen/efi.c
+++ b/arch/x86/xen/efi.c
@@ -15,12 +15,14 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <linux/bitops.h>
 #include <linux/efi.h>
 #include <linux/init.h>
 #include <linux/string.h>
 
 #include <xen/xen-ops.h>
 
+#include <asm/page.h>
 #include <asm/setup.h>
 
 void __init xen_efi_init(void)
diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index 31f618a..1f850c9 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -27,6 +27,8 @@
 #include <xen/interface/platform.h>
 #include <xen/xen.h>
 
+#include <asm/page.h>
+
 #include <asm/xen/hypercall.h>
 
 #define INIT_EFI_OP(name) \
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-09-09 11:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-08 13:22 [PATCH] xen/efi: Directly include needed headers Daniel Kiper
2014-09-08 17:35 ` David Vrabel
2014-09-08 17:35 ` [Xen-devel] " David Vrabel
2014-09-09 11:28   ` Daniel Kiper
2014-09-09 11:28   ` [Xen-devel] " Daniel Kiper
  -- strict thread matches above, loose matches on Subject: below --
2014-09-08 13:22 Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.