From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Date: Mon, 08 Sep 2014 21:23:05 +0200
Subject: [U-Boot] [PATCH 09/10] kconfig: move CONFIG_OF_* to Kconfig
In-Reply-To: <1410079409-28450-10-git-send-email-yamada.m@jp.panasonic.com>
References: <1410079409-28450-1-git-send-email-yamada.m@jp.panasonic.com>
	<1410079409-28450-10-git-send-email-yamada.m@jp.panasonic.com>
Message-ID: <540E0219.6050001@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Masahiro,

On 07.09.2014 10:43, Masahiro Yamada wrote:
> This commit moves:
>   CONFIG_OF_CONTROL
>   CONFIG_OF_SEPARATE
>   CONFIG_OF_EMBED
>   CONFIG_OF_HOSTFILE
> 
> Because these options are currently not supported for SPL,
> the "Device Tree Control" menu does not appear in the SPL
> configuration.
> 
> Note:
> zynq-common.h should be adjusted so as not to change the
> default value of CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---

[...]

> diff --git a/dts/Kconfig b/dts/Kconfig
> new file mode 100644
> index 0000000..98b2357
> --- /dev/null
> +++ b/dts/Kconfig
> @@ -0,0 +1,46 @@
> +#
> +# Device Tree Control
> +#
> +# TODO:
> +#   This feature is not currently supported for SPL,
> +#    but this restriction should be removed in the future.
> +
> +menu "Device Tree Control"
> +	depends on !SPL_BUILD
> +	depends on ARM || MICROBLAZE || SANDBOX || X86

I suggest to use boolean symbols HAS_* or SUPPORTS_* like the kernel
does. For example:

config SUPPORTS_OF_CONTROL
        bool

menu "Device Tree Control"
        depends on !SPL_BUILD
        depends on SUPPORTS_OF_CONTROL


arch/Kconfig:
config ARM
        bool "ARM architecture"
        select SUPPORTS_OF_CONTROL


> +
> +config OF_CONTROL
> +	bool "Run-time configuration via Device Tree"
> +	help
> +	  This feature provides for run-time configuration of U-Boot
> +	  via a flattened device tree.
> +
> +choice
> +	prompt "Provider of DTB for DT control"
> +	depends on OF_CONTROL
> +	default OF_HOSTFILE if SANDBOX
> +	default OF_SEPARATE
> +
> +config OF_SEPARATE
> +	bool "Separate DTB for DT control"
> +	help
> +	  If this option is enabled, the device tree will be built and
> +	  placed as a separate u-boot.dtb file alongside the U-Boot image.
> +
> +config OF_EMBED
> +	bool "Embedded DTB for DT control"
> +	help
> +	  If this option is enabled, the device tree will be picked up and
> +	  built into the U-Boot image.
> +
> +config OF_HOSTFILE
> +	bool "Host filed DTB for DT control"
> +	depends on SANDBOX
> +	help
> +	  If this option is enabled, DTB will be read from a file on startup.
> +	  This is only useful for Sandbox.  Use the -d flag to U-Boot to
> +	  specify the file to read.
> +
> +endchoice
> +
> +endmenu
> 

-- 
- Daniel