From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "mesa-dev@lists.freedesktop.org" <mesa-dev@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag
Date: Tue, 09 Sep 2014 09:47:36 +0900 [thread overview]
Message-ID: <540E4E28.50701@daenzer.net> (raw)
In-Reply-To: <CADnq5_PjfMrdw4oRZOGyRvU5BLbiVLHpSeLZ+-sC4ChEu8bf2w@mail.gmail.com>
On 09.09.2014 02:36, Alex Deucher wrote:
>
> Updated version with comments integrated.
[...]
> @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo *bo, u32 domain, u64 max_offset,
> unsigned lpfn = 0;
>
> /* force to pin into visible video ram */
> - if (bo->placements[i].flags & TTM_PL_FLAG_VRAM)
> - lpfn = bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
> - else
> + if (bo->placements[i].flags & TTM_PL_FLAG_VRAM) {
> + if (!(bo->flags & RADEON_GEM_NO_CPU_ACCESS))
> + lpfn = bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
> + } else {
> lpfn = bo->rdev->mc.gtt_size >> PAGE_SHIFT; /* ??? */
> + }
The else block can be removed as well, but that can be done in another
patch.
Either way, v2 is
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2014-09-09 0:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 6:56 [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag Michel Dänzer
2014-08-28 6:56 ` [PATCH] r600g, radeonsi: Inform the kernel if a BO will likely be accessed by the CPU Michel Dänzer
2014-09-01 10:21 ` [Mesa-dev] " Marek Olšák
2014-08-28 8:57 ` [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag Christian König
2014-08-28 15:01 ` Alex Deucher
2014-08-29 1:46 ` [Mesa-dev] " Michel Dänzer
2014-09-08 17:36 ` Alex Deucher
2014-09-09 0:47 ` Michel Dänzer [this message]
2014-09-09 1:15 ` Michel Dänzer
2014-09-09 16:28 ` Alex Deucher
2014-09-10 4:03 ` Michel Dänzer
2014-09-10 13:40 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E4E28.50701@daenzer.net \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.