From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRLRM-0004Ma-FD for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRLRE-00017u-OQ for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRLRE-00017g-HG for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:28 -0400 Message-ID: <540EFFF9.7050301@redhat.com> Date: Tue, 09 Sep 2014 15:26:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com> <1410265809-27247-4-git-send-email-pbonzini@redhat.com> <87fvg12afd.fsf@troll.troll> In-Reply-To: <87fvg12afd.fsf@troll.troll> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] cpu: init vmstate for ticks and clock offset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, dgilbert@redhat.com Il 09/09/2014 15:25, Juan Quintela ha scritto: > Nack. > > This break migration when using with older machine types. The other way round---this was broken recently, the patch fixes it. Paolo > Several questions before I propose an alternative: > - are we this fields always needed (then why migration has worked until > now) > - after reding cpus.c the question is .... why it ever worked? > > > After reading cpus.c, it appears that we only really need this > functionality for > > qemu_clock_get_ns() > > when called with QEMU_CLOCK_VIRTUAL with icount disabled, right? > > further grep shows that it is used for acpi_pm_tmr_get_clock, whatever > that is. When is this used, thanks?