From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbaIJIpn (ORCPT ); Wed, 10 Sep 2014 04:45:43 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:8636 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbaIJIpk (ORCPT ); Wed, 10 Sep 2014 04:45:40 -0400 Message-ID: <54100FB0.1000308@imgtec.com> Date: Wed, 10 Sep 2014 09:45:36 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Ricardo Ribalda Delgado CC: Greg KH , , , LKML , Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions References: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> <20140909191736.GA7467@kroah.com> <54100AE5.6050401@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.67] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote: > Hello Greg > > Sorry, Probably my bad :). I did resend a new patch using the _IO* > macros, that has been now merged to tty-next > > Regards! > > On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras > wrote: >> On 09/09/2014 08:17 PM, Greg KH wrote: >>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: >>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676 >>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the >>>> TIOC{S,G}RS485 commands but this broke the build for MIPS: >>>> >>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': >>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared >>>> (first use in this function) >>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared >>>> (first use in this function) >>>> >>>> This patch adds these missing definitions >>>> >>>> Cc: Ricardo Ribalda Delgado >>>> Cc: >>>> Cc: >>>> Cc: >>>> Signed-off-by: Markos Chandras >>>> --- >>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h >>>> index b1e637757fe3..34050cb6b631 100644 >>>> --- a/arch/mips/include/uapi/asm/ioctls.h >>>> +++ b/arch/mips/include/uapi/asm/ioctls.h >>>> @@ -76,6 +76,8 @@ >>>> >>>> #define TIOCSBRK 0x5427 /* BSD compatibility */ >>>> #define TIOCCBRK 0x5428 /* BSD compatibility */ >>>> +#define TIOCGRS485 0x542E >>>> +#define TIOCSRS485 0x542F >>> >>> Any reason you aren't using the _IOR() type macros here? >>> >>> thanks, >>> >>> greg k-h >>> >> Hi Greg, >> >> Not really. I am being consistent with what >> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch >> that was posted yesterday >> >> https://lkml.org/lkml/2014/9/9/27 >> >> -- >> markos > > > Hi Ricardo, Since you are taking care of the same problem on the other architectures, could you also make a similar patch for MIPS so they can all get merged via the same tree? Because, right now, MIPS is still broken. -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markos Chandras Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions Date: Wed, 10 Sep 2014 09:45:36 +0100 Message-ID: <54100FB0.1000308@imgtec.com> References: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> <20140909191736.GA7467@kroah.com> <54100AE5.6050401@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-serial-owner@vger.kernel.org To: Ricardo Ribalda Delgado Cc: Greg KH , linux-mips@linux-mips.org, linux-next@vger.kernel.org, LKML , linux-serial@vger.kernel.org List-Id: linux-next.vger.kernel.org On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote: > Hello Greg > > Sorry, Probably my bad :). I did resend a new patch using the _IO* > macros, that has been now merged to tty-next > > Regards! > > On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras > wrote: >> On 09/09/2014 08:17 PM, Greg KH wrote: >>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: >>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676 >>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the >>>> TIOC{S,G}RS485 commands but this broke the build for MIPS: >>>> >>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': >>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared >>>> (first use in this function) >>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared >>>> (first use in this function) >>>> >>>> This patch adds these missing definitions >>>> >>>> Cc: Ricardo Ribalda Delgado >>>> Cc: >>>> Cc: >>>> Cc: >>>> Signed-off-by: Markos Chandras >>>> --- >>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h >>>> index b1e637757fe3..34050cb6b631 100644 >>>> --- a/arch/mips/include/uapi/asm/ioctls.h >>>> +++ b/arch/mips/include/uapi/asm/ioctls.h >>>> @@ -76,6 +76,8 @@ >>>> >>>> #define TIOCSBRK 0x5427 /* BSD compatibility */ >>>> #define TIOCCBRK 0x5428 /* BSD compatibility */ >>>> +#define TIOCGRS485 0x542E >>>> +#define TIOCSRS485 0x542F >>> >>> Any reason you aren't using the _IOR() type macros here? >>> >>> thanks, >>> >>> greg k-h >>> >> Hi Greg, >> >> Not really. I am being consistent with what >> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch >> that was posted yesterday >> >> https://lkml.org/lkml/2014/9/9/27 >> >> -- >> markos > > > Hi Ricardo, Since you are taking care of the same problem on the other architectures, could you also make a similar patch for MIPS so they can all get merged via the same tree? Because, right now, MIPS is still broken. -- markos