From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRvrN-0001z6-De for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:19:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRvrI-0007dS-FY for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:19:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRvrI-0007dO-7V for qemu-devel@nongnu.org; Thu, 11 Sep 2014 00:19:48 -0400 Message-ID: <541122E1.6080005@redhat.com> Date: Wed, 10 Sep 2014 22:19:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410352239-8705-1-git-send-email-famz@redhat.com> <1410397360-14174-1-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1410397360-14174-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iQcE0670a25eV0kSsPoVcUoKBAuwVfgR5" Subject: Re: [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iQcE0670a25eV0kSsPoVcUoKBAuwVfgR5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/10/2014 07:02 PM, Michael Roth wrote: > This more an exercise of the dealloc visitor, where it may erroneously This is more of an exercise... > use an uninitialized discriminator field as indication that union > fields corresponding to that disciminator field/type are present, discriminator > which can lead to attempts to free random chunks of heap memory. >=20 > Signed-off-by: Michael Roth > --- > tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++ > tests/qapi-schema/qapi-schema-test.out | 3 +++ > tests/test-qmp-input-strict.c | 17 +++++++++++++++++ > 3 files changed, 30 insertions(+) >=20 Reviewed-by: Eric Blake [conflicts with my stalled attempt to nuke inline sub-structs in json files, where I've promised to send a v4 - guess I'll be rebasing as part of reviving that series...] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iQcE0670a25eV0kSsPoVcUoKBAuwVfgR5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUESLhAAoJEKeha0olJ0NqFYsH/0hd9IkcPyc78TSNm+yTyNON MdqXDzNJLbiWwidHvMjuFED4BGRWQ87uQ1tnOttPZATrCaNlhIng8KPyZne6EX7l DiJTzPFzri1GK9JYxzW754E+8R5QFQ2yJOR9/v98pe7N/sD8iH+iaJfHBvmqzHqV M501kdW3uqE6blTqXvOAV83liOpL0cM+i8Nq0dibCWsLF5p/icLJoCUeaVpPrswe WNbw5Ddz3vpNOJ++/oAQHQFkUBTE4ob8uIvESVmd+Pf1+Hl6qVm+senZ/iuEnX8A Ad/ycCcqqo6BEA2bAEF8VnK8bwAZj3wk9eyb7xU7tyrMJvGGazVXmfy8GPUtPzg= =LPqv -----END PGP SIGNATURE----- --iQcE0670a25eV0kSsPoVcUoKBAuwVfgR5--