From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRxxB-00079Z-8f for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:34:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRxx5-0004pi-3c for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:34:01 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:5160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRxx4-0004pE-De for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:33:55 -0400 Message-ID: <5411423D.5070401@huawei.com> Date: Thu, 11 Sep 2014 14:33:33 +0800 From: zhanghailiang MIME-Version: 1.0 References: <54101328.4070802@huawei.com> <54110187.7060107@linux.vnet.ibm.com> <54113F97.7070602@redhat.com> <541140C3.5020809@linux.vnet.ibm.com> In-Reply-To: <541140C3.5020809@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: Paolo Bonzini , hinesmr@cn.ibm.com, qemu-devel , Alexandre DERUMIER On 2014/9/11 14:27, Michael R. Hines wrote: > On 09/11/2014 02:22 PM, Paolo Bonzini wrote: >> Il 11/09/2014 03:57, Michael R. Hines ha scritto: >>> Why does hotplugging use a different name? >>> >>> This also affects RDMA live migration - we are explicitly looking up >>> "pc.ram" ram blocks and pinning them for memory registration with Linux. >> Are we? I cannot see any code that special cases pc.ram (it only >> appears in a couple of comments). It'd also be surprising to see that >> escaping review. :) >> >> Paolo >> > > > You're absolutely right =) I was thinking about old code. We loop through all the ram blocks. > > Good sanity check, though =) > > - Michael > > > Hmm, in this case, it is better to remove this confused comments;-)