From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbaIKJSM (ORCPT ); Thu, 11 Sep 2014 05:18:12 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:52240 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbaIKJSJ (ORCPT ); Thu, 11 Sep 2014 05:18:09 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-KSVirus-check: 0 X-RL-SENDER: addy.ke@rock-chips.com X-FST-TO: dianders@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: addy.ke@rock-chips.com X-UNIQUE-TAG: X-DNS-TYPE: 0 Message-ID: <541168C6.2090603@rock-chips.com> Date: Thu, 11 Sep 2014 17:17:58 +0800 From: Addy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Anderson , Heiko Stuebner CC: Chris Zhong , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808 References: <1410409815-22200-1-git-send-email-dianders@chromium.org> In-Reply-To: <1410409815-22200-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 Sep 2014 12:30, Doug Anderson writes: > We should be able to talk to the PMIC at 400kHz. No need to talk at > the slow 100kHz. > > As measured by ftrace (with a bunch of extra patches, since cpufreq > for rk808 hasn't landed yet): > before this change: cpu0_set_target() => ~500us > after this change: cpu0_set_target() => ~300us > > Signed-off-by: Doug Anderson > --- > arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts > index 36db177..ff522f8 100644 > --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts > +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts > @@ -18,6 +18,7 @@ > }; > > &i2c0 { > + clock-frequency = <400000>; > status = "okay"; > > rk808: pmic@1b { I have tested on rk3288-pinky board, it work well. so Reviewed-by Addy Ke Tested-by Addy Ke From mboxrd@z Thu Jan 1 00:00:00 1970 From: Addy Subject: Re: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808 Date: Thu, 11 Sep 2014 17:17:58 +0800 Message-ID: <541168C6.2090603@rock-chips.com> References: <1410409815-22200-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410409815-22200-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson , Heiko Stuebner Cc: Chris Zhong , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 11 Sep 2014 12:30, Doug Anderson writes: > We should be able to talk to the PMIC at 400kHz. No need to talk at > the slow 100kHz. > > As measured by ftrace (with a bunch of extra patches, since cpufreq > for rk808 hasn't landed yet): > before this change: cpu0_set_target() => ~500us > after this change: cpu0_set_target() => ~300us > > Signed-off-by: Doug Anderson > --- > arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts > index 36db177..ff522f8 100644 > --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts > +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts > @@ -18,6 +18,7 @@ > }; > > &i2c0 { > + clock-frequency = <400000>; > status = "okay"; > > rk808: pmic@1b { I have tested on rk3288-pinky board, it work well. so Reviewed-by Addy Ke Tested-by Addy Ke -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: addy.ke@rock-chips.com (Addy) Date: Thu, 11 Sep 2014 17:17:58 +0800 Subject: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808 In-Reply-To: <1410409815-22200-1-git-send-email-dianders@chromium.org> References: <1410409815-22200-1-git-send-email-dianders@chromium.org> Message-ID: <541168C6.2090603@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11 Sep 2014 12:30, Doug Anderson writes: > We should be able to talk to the PMIC at 400kHz. No need to talk at > the slow 100kHz. > > As measured by ftrace (with a bunch of extra patches, since cpufreq > for rk808 hasn't landed yet): > before this change: cpu0_set_target() => ~500us > after this change: cpu0_set_target() => ~300us > > Signed-off-by: Doug Anderson > --- > arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts > index 36db177..ff522f8 100644 > --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts > +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts > @@ -18,6 +18,7 @@ > }; > > &i2c0 { > + clock-frequency = <400000>; > status = "okay"; > > rk808: pmic at 1b { I have tested on rk3288-pinky board, it work well. so Reviewed-by Addy Ke Tested-by Addy Ke