All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@suse.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
Subject: Re: [libvirt] [PATCH V3 4/5] libxl: fix mapping of lifecycle actions
Date: Thu, 11 Sep 2014 15:56:36 -0600	[thread overview]
Message-ID: <54121A94.7080602__15709.8713484176$1410472743$gmane$org@suse.com> (raw)
In-Reply-To: <20140911104716.GD7035@redhat.com>

Daniel P. Berrange wrote:
> On Wed, Sep 03, 2014 at 09:07:38PM -0600, Jim Fehlig wrote:
>   
>> The libxl driver was blindly assigning libvirt's
>> virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when
>> in fact the various actions take on different values in these enums.
>>
>> Introduce helpers to properly map the enum values.
>>
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>> ---
>>  src/libxl/libxl_conf.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++---
>>  1 file changed, 59 insertions(+), 3 deletions(-)
>>     
>
> ACK
>   

Thanks.  I've pushed 2-4.

Regards,
Jim

  parent reply	other threads:[~2014-09-11 21:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  3:07 [PATCH V3 0/5] Testing libvirt XML -> libxl_domain_config conversion Jim Fehlig
2014-09-04  3:07 ` [PATCH V3 1/5] util: Introduce virJSONStringCompare for JSON doc comparisons Jim Fehlig
2014-09-04  3:07 ` [PATCH V3 2/5] util: Allow port allocator to skip bind() check Jim Fehlig
2014-09-11 10:46   ` Daniel P. Berrange
2014-09-04  3:07 ` [PATCH V3 3/5] tests: Add more test suite mock helpers Jim Fehlig
2014-09-11 10:46   ` Daniel P. Berrange
2014-09-04  3:07 ` [PATCH V3 4/5] libxl: fix mapping of lifecycle actions Jim Fehlig
2014-09-04  3:07 ` [PATCH V3 5/5] libxl: Add a test suite for libxl option generator Jim Fehlig
2014-09-11 10:58   ` Daniel P. Berrange
     [not found]   ` <20140911105842.GE7035@redhat.com>
2014-09-11 22:01     ` Jim Fehlig
     [not found] ` <1409800059-16884-2-git-send-email-jfehlig@suse.com>
2014-09-11 10:45   ` [PATCH V3 1/5] util: Introduce virJSONStringCompare for JSON doc comparisons Daniel P. Berrange
     [not found]   ` <20140911104519.GA7035@redhat.com>
2014-09-11 21:57     ` Jim Fehlig
     [not found] ` <1409800059-16884-5-git-send-email-jfehlig@suse.com>
2014-09-11 10:47   ` [libvirt] [PATCH V3 4/5] libxl: fix mapping of lifecycle actions Daniel P. Berrange
     [not found]   ` <20140911104716.GD7035@redhat.com>
2014-09-11 21:56     ` Jim Fehlig [this message]
2014-09-11 21:59   ` Jim Fehlig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='54121A94.7080602__15709.8713484176$1410472743$gmane$org@suse.com' \
    --to=jfehlig@suse.com \
    --cc=berrange@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.