From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH V3 4/5] libxl: fix mapping of lifecycle actions Date: Thu, 11 Sep 2014 15:59:03 -0600 Message-ID: <54121B27.6050106__30612.4910865494$1410472895$gmane$org@suse.com> References: <1409800059-16884-1-git-send-email-jfehlig@suse.com> <1409800059-16884-5-git-send-email-jfehlig@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409800059-16884-5-git-send-email-jfehlig@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: libvir-list@redhat.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Jim Fehlig wrote: > The libxl driver was blindly assigning libvirt's > virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when > in fact the various actions take on different values in these enums. > > Introduce helpers to properly map the enum values. > BTW, forgot to mention that this is the first bug found by the proposed unit tests :-). Regards, Jim