From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 06/21] xen/arm: Allow virq != irq Date: Thu, 11 Sep 2014 15:50:10 -0700 Message-ID: <54122722.6060901@linaro.org> References: <1406818852-31856-1-git-send-email-julien.grall@linaro.org> <1406818852-31856-7-git-send-email-julien.grall@linaro.org> <1410269384.8217.178.camel@kazak.uk.xensource.com> <540F49FE.9020500@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XSEFU-0002YV-H2 for xen-devel@lists.xenproject.org; Thu, 11 Sep 2014 23:58:00 +0000 Received: by mail-qa0-f44.google.com with SMTP id w8so1789711qac.17 for ; Thu, 11 Sep 2014 16:57:58 -0700 (PDT) In-Reply-To: <540F49FE.9020500@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/09/14 11:42, Julien Grall wrote: >>> - vgic_vcpu_inject_spi(d, irq); >>> + vgic_vcpu_inject_spi(info->d, info->virq); >> >> Could this function take an irq_guest* or are there other callers? > > I haven't thought about this possibility. This is the only caller, so I > will pass irq_guest. Looking again to this code, I've defined the structure irq_guest directly in arch/arm/irq.c. And I don't really want to move the definition in header as all the use are within this single file. I will stay with the current solution. Regards, -- Julien Grall