All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031
@ 2014-09-11 13:45 Mike Looijmans
  2014-09-11 18:41 ` Florian Fainelli
  0 siblings, 1 reply; 9+ messages in thread
From: Mike Looijmans @ 2014-09-11 13:45 UTC (permalink / raw)
  To: f.fainelli, netdev; +Cc: linux-kernel, Mike Looijmans

Our KSZ9031 appears to suffer from the same hardware bug as described
for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577,
you have to unplug the cable and plug it back to get it to work.

Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/net/phy/micrel.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 5a8993b..a932a35 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = {
 	.phy_id		= PHY_ID_KSZ9031,
 	.phy_id_mask	= 0x00fffff0,
 	.name		= "Micrel KSZ9031 Gigabit PHY",
-	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
-				| SUPPORTED_Asym_Pause),
+	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
 	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
 	.config_init	= kszphy_config_init,
 	.config_aneg	= genphy_config_aneg,
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-11 13:45 [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 Mike Looijmans
@ 2014-09-11 18:41 ` Florian Fainelli
  2014-09-12  6:54   ` Mike Looijmans
  2014-09-12 12:40   ` [PATCH v2] " Mike Looijmans
  0 siblings, 2 replies; 9+ messages in thread
From: Florian Fainelli @ 2014-09-11 18:41 UTC (permalink / raw)
  To: Mike Looijmans, netdev; +Cc: linux-kernel

On 09/11/2014 06:45 AM, Mike Looijmans wrote:
> Our KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577,
> you have to unplug the cable and plug it back to get it to work.
> 
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.

Can you resend this patch specifying the commit subject in parenthesis
like this:

commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 ("net/phy: micrel:
Disable asymmetric pause for KSZ9021")

since this is a bugfix, it should probably be targeting the 'net' tree,
rather than the 'net-next' tree, though the patch applies to both cleanly.

Other than that:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  drivers/net/phy/micrel.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 5a8993b..a932a35 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = {
>  	.phy_id		= PHY_ID_KSZ9031,
>  	.phy_id_mask	= 0x00fffff0,
>  	.name		= "Micrel KSZ9031 Gigabit PHY",
> -	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
> -				| SUPPORTED_Asym_Pause),
> +	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
>  	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
>  	.config_init	= kszphy_config_init,
>  	.config_aneg	= genphy_config_aneg,
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-11 18:41 ` Florian Fainelli
@ 2014-09-12  6:54   ` Mike Looijmans
  2014-09-12 12:40   ` [PATCH v2] " Mike Looijmans
  1 sibling, 0 replies; 9+ messages in thread
From: Mike Looijmans @ 2014-09-12  6:54 UTC (permalink / raw)
  To: Florian Fainelli, netdev; +Cc: linux-kernel

On 09/11/2014 08:41 PM, Florian Fainelli wrote:
> On 09/11/2014 06:45 AM, Mike Looijmans wrote:
>> Our KSZ9031 appears to suffer from the same hardware bug as described
>> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577,
>> you have to unplug the cable and plug it back to get it to work.
>>
>> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
>
> Can you resend this patch specifying the commit subject in parenthesis
> like this:
>
> commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 ("net/phy: micrel:
> Disable asymmetric pause for KSZ9021")

I'll amend the text body and resend the patch.

> since this is a bugfix, it should probably be targeting the 'net' tree,
> rather than the 'net-next' tree, though the patch applies to both cleanly.

I assume this does not require any action on my side? I actually based 
this patch on a 3.14 kernel.


> Other than that:
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   drivers/net/phy/micrel.c |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>> index 5a8993b..a932a35 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = {
>>   	.phy_id		= PHY_ID_KSZ9031,
>>   	.phy_id_mask	= 0x00fffff0,
>>   	.name		= "Micrel KSZ9031 Gigabit PHY",
>> -	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
>> -				| SUPPORTED_Asym_Pause),
>> +	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
>>   	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
>>   	.config_init	= kszphy_config_init,
>>   	.config_aneg	= genphy_config_aneg,
>>
>


-- 
Mike Looijmans

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-11 18:41 ` Florian Fainelli
  2014-09-12  6:54   ` Mike Looijmans
@ 2014-09-12 12:40   ` Mike Looijmans
  2014-09-12 22:18     ` David Miller
  1 sibling, 1 reply; 9+ messages in thread
From: Mike Looijmans @ 2014-09-12 12:40 UTC (permalink / raw)
  To: f.fainelli; +Cc: netdev, linux-kernel, Mike Looijmans

The KSZ9031 appears to suffer from the same hardware bug as described
for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
("net/phy: micrel: Disable asymmetric pause for KSZ9021")
you have to unplug the cable and plug it back to get it to work.

Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/net/phy/micrel.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 5a8993b..a932a35 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = {
 	.phy_id		= PHY_ID_KSZ9031,
 	.phy_id_mask	= 0x00fffff0,
 	.name		= "Micrel KSZ9031 Gigabit PHY",
-	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
-				| SUPPORTED_Asym_Pause),
+	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
 	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
 	.config_init	= kszphy_config_init,
 	.config_aneg	= genphy_config_aneg,
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-12 12:40   ` [PATCH v2] " Mike Looijmans
@ 2014-09-12 22:18     ` David Miller
  2014-09-15  7:44       ` Mike Looijmans
  2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
  0 siblings, 2 replies; 9+ messages in thread
From: David Miller @ 2014-09-12 22:18 UTC (permalink / raw)
  To: mike.looijmans; +Cc: f.fainelli, netdev, linux-kernel

From: Mike Looijmans <mike.looijmans@topic.nl>
Date: Fri, 12 Sep 2014 14:40:37 +0200

> The KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
> ("net/phy: micrel: Disable asymmetric pause for KSZ9021")
> you have to unplug the cable and plug it back to get it to work.
> 
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>

This patch does not apply cleanly to the net tree, please respin.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-12 22:18     ` David Miller
@ 2014-09-15  7:44       ` Mike Looijmans
  2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
  1 sibling, 0 replies; 9+ messages in thread
From: Mike Looijmans @ 2014-09-15  7:44 UTC (permalink / raw)
  To: David Miller; +Cc: f.fainelli, netdev, linux-kernel

On 09/13/2014 12:18 AM, David Miller wrote:
> From: Mike Looijmans <mike.looijmans@topic.nl>
> Date: Fri, 12 Sep 2014 14:40:37 +0200
>
>> The KSZ9031 appears to suffer from the same hardware bug as described
>> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
>> ("net/phy: micrel: Disable asymmetric pause for KSZ9021")
>> you have to unplug the cable and plug it back to get it to work.
>>
>> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>
> This patch does not apply cleanly to the net tree, please respin.
>

Okay, just tell me where to find this branch?

Mike.


Met vriendelijke groet / kind regards,

Mike Looijmans

TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v3] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-12 22:18     ` David Miller
  2014-09-15  7:44       ` Mike Looijmans
@ 2014-09-15 10:06       ` Mike Looijmans
  2014-09-15 10:07         ` Mike Looijmans
  2014-09-15 18:24         ` David Miller
  1 sibling, 2 replies; 9+ messages in thread
From: Mike Looijmans @ 2014-09-15 10:06 UTC (permalink / raw)
  To: f.fainelli, netdev; +Cc: linux-kernel, Mike Looijmans

The KSZ9031 appears to suffer from the same hardware bug as described
for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
("net/phy: micrel: Disable asymmetric pause for KSZ9021")
you have to unplug the cable and plug it back to get it to work.

Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/net/phy/micrel.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index fd0ea7c..011dbda 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -592,8 +592,7 @@ static struct phy_driver ksphy_driver[] = {
 	.phy_id		= PHY_ID_KSZ9031,
 	.phy_id_mask	= 0x00fffff0,
 	.name		= "Micrel KSZ9031 Gigabit PHY",
-	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
-				| SUPPORTED_Asym_Pause),
+	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
 	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
 	.config_init	= ksz9031_config_init,
 	.config_aneg	= genphy_config_aneg,
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v3] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
@ 2014-09-15 10:07         ` Mike Looijmans
  2014-09-15 18:24         ` David Miller
  1 sibling, 0 replies; 9+ messages in thread
From: Mike Looijmans @ 2014-09-15 10:07 UTC (permalink / raw)
  To: f.fainelli, netdev; +Cc: linux-kernel, Mike Looijmans

I based this patch on the 3.17rc5 state. Hope this applies cleanly now?


On 09/15/2014 12:06 PM, Mike Looijmans wrote:
> The KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
> ("net/phy: micrel: Disable asymmetric pause for KSZ9021")
> you have to unplug the cable and plug it back to get it to work.
>
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>   drivers/net/phy/micrel.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index fd0ea7c..011dbda 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -592,8 +592,7 @@ static struct phy_driver ksphy_driver[] = {
>   	.phy_id		= PHY_ID_KSZ9031,
>   	.phy_id_mask	= 0x00fffff0,
>   	.name		= "Micrel KSZ9031 Gigabit PHY",
> -	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause
> -				| SUPPORTED_Asym_Pause),
> +	.features	= (PHY_GBIT_FEATURES | SUPPORTED_Pause),
>   	.flags		= PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
>   	.config_init	= ksz9031_config_init,
>   	.config_aneg	= genphy_config_aneg,
>



Met vriendelijke groet / kind regards,

Mike Looijmans

TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3] net/phy: micrel: Disable asymmetric pause for KSZ9031
  2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
  2014-09-15 10:07         ` Mike Looijmans
@ 2014-09-15 18:24         ` David Miller
  1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2014-09-15 18:24 UTC (permalink / raw)
  To: mike.looijmans; +Cc: f.fainelli, netdev, linux-kernel

From: Mike Looijmans <mike.looijmans@topic.nl>
Date: Mon, 15 Sep 2014 12:06:33 +0200

> The KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577
> ("net/phy: micrel: Disable asymmetric pause for KSZ9021")
> you have to unplug the cable and plug it back to get it to work.
> 
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-09-15 18:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-11 13:45 [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 Mike Looijmans
2014-09-11 18:41 ` Florian Fainelli
2014-09-12  6:54   ` Mike Looijmans
2014-09-12 12:40   ` [PATCH v2] " Mike Looijmans
2014-09-12 22:18     ` David Miller
2014-09-15  7:44       ` Mike Looijmans
2014-09-15 10:06       ` [PATCH v3] " Mike Looijmans
2014-09-15 10:07         ` Mike Looijmans
2014-09-15 18:24         ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.