From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754127AbaILJ1v (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Sep 2014 05:27:51 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:29439 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754088AbaILJ1r (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Sep 2014 05:27:47 -0400
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
X-AuditID: cbfec7f4-b7f156d0000063c7-87-5412bc90be6c
Content-transfer-encoding: 8BIT
Message-id: <5412BC8D.2030007@samsung.com>
Date: Fri, 12 Sep 2014 11:27:41 +0200
From: Andrzej Hajda <a.hajda@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.0
To: Inki Dae <inki.dae@samsung.com>,
        "moderated list:ARM/S5P EXYNOS AR..." 
	<linux-samsung-soc@vger.kernel.org>,
        Seung-Woo Kim <sw0312.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>,
        dri-devel@lists.freedesktop.org,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence
References: <1410268573-2297-1-git-send-email-a.hajda@samsung.com>
 <1410268573-2297-6-git-send-email-a.hajda@samsung.com>
 <5412B02A.6040609@samsung.com> <20140912085710.GD4740@phenom.ffwll.local>
In-reply-to: <20140912085710.GD4740@phenom.ffwll.local>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCLMWRmVeSWpSXmKPExsVy+t/xa7oT9giFGJw8om1x5et7NotJ9yew
	WJxtesNucXnXHDaLGef3MVmsPXKX3WLG5JdsDuwe97uPM3n0bVnF6PF5k1wAcxSXTUpqTmZZ
	apG+XQJXxq8v1xgL+tQqpn8MbmCcqNDFyMkhIWAiMbF7DROELSZx4d56ti5GLg4hgaWMEut3
	NLKCJHgFBCV+TL7H0sXIwcEsIC9x5FI2hKkuMWVKLkT5J0aJuV0TWCDKtSQWnj7CCGKzCKhK
	fP67B8xmE9CU+Lv5JhuILSoQJvHs10EmkGYRgcNMErevHWIHSQgL+EgcuLqTHWLqcUaJ5vut
	rCDbOAXMJW6tj5nAyD8LyUmzEE6ahXDSAkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxgh
	IftlB+PiY1aHGAU4GJV4eDnOCYYIsSaWFVfmHmKU4GBWEuH9uU0oRIg3JbGyKrUoP76oNCe1
	+BAjEwenVAOjsHTHPdcT57ljDhyKXRmZICs5Teft7+/8d6eXyfFzaV7Wnmi7W+v4XCdhE0ZX
	H72v7ZcUHeqymje5rn7VVDRfZUXAw2Nyt1R5Mk40yp6W4Uu+Mvnb2skajnPq1Q5pienv+eRx
	9gBjjXSRwc6+5vTtytnH2sRcrmgvefFSRNPh38Mms5M8wneVWIozEg21mIuKEwEcKKLsNwIA	AA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/12/2014 10:57 AM, Daniel Vetter wrote:
> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote:
>> Hi Andrzej,
>>
>> On 2014년 09월 09일 22:16, Andrzej Hajda wrote:
>>> Adding reference to framebuffer should be accompanied with removing
>>> reference to old framebuffer assigned to the plane.
>>> This patch removes following warning:
>>>
>>> [   95.038017] WARNING: CPU: 1 PID: 3067 at drivers/gpu/drm/drm_crtc.c:5115 drm_mode_config_cleanup+0x258/0x268()
>>> [   95.048086] Modules linked in:
>>> [   95.051430] CPU: 1 PID: 3067 Comm: bash Tainted: G        W      3.16.0-11355-g7a6eca5-dirty #3015
>>> [   95.060058] [<c0013e90>] (unwind_backtrace) from [<c0011128>] (show_stack+0x10/0x14)
>>> [   95.067766] [<c0011128>] (show_stack) from [<c04a5dc4>] (dump_stack+0x70/0xbc)
>>> [   95.074953] [<c04a5dc4>] (dump_stack) from [<c0021784>] (warn_slowpath_common+0x64/0x88)
>>> [   95.083005] [<c0021784>] (warn_slowpath_common) from [<c00217c4>] (warn_slowpath_null+0x1c/0x24)
>>> [   95.091780] [<c00217c4>] (warn_slowpath_null) from [<c0275fa0>] (drm_mode_config_cleanup+0x258/0x268)
>>> [   95.100983] [<c0275fa0>] (drm_mode_config_cleanup) from [<c0281724>] (exynos_drm_unload+0x38/0x50)
>>> [   95.109915] [<c0281724>] (exynos_drm_unload) from [<c026e248>] (drm_dev_unregister+0x24/0x98)
>>> [   95.118414] [<c026e248>] (drm_dev_unregister) from [<c026ecb0>] (drm_put_dev+0x28/0x64)
>>> [   95.126412] [<c026ecb0>] (drm_put_dev) from [<c02947c4>] (take_down_master+0x24/0x44)
>>> [   95.134218] [<c02947c4>] (take_down_master) from [<c0294870>] (component_del+0x8c/0xc8)
>>> [   95.142201] [<c0294870>] (component_del) from [<c0286c10>] (exynos_dsi_remove+0x18/0x2c)
>>> [   95.150294] [<c0286c10>] (exynos_dsi_remove) from [<c0299e04>] (platform_drv_remove+0x18/0x1c)
>>> [   95.158872] [<c0299e04>] (platform_drv_remove) from [<c02987a4>] (__device_release_driver+0x70/0xc4)
>>> [   95.167981] [<c02987a4>] (__device_release_driver) from [<c0298818>] (device_release_driver+0x20/0x2c)
>>> [   95.177268] [<c0298818>] (device_release_driver) from [<c02979d0>] (unbind_store+0x5c/0x94)
>>> [   95.185597] [<c02979d0>] (unbind_store) from [<c0297278>] (drv_attr_store+0x20/0x2c)
>>> [   95.193323] [<c0297278>] (drv_attr_store) from [<c012aa90>] (sysfs_kf_write+0x4c/0x50)
>>> [   95.201224] [<c012aa90>] (sysfs_kf_write) from [<c0129e94>] (kernfs_fop_write+0xc4/0x184)
>>> [   95.209393] [<c0129e94>] (kernfs_fop_write) from [<c00d03ec>] (vfs_write+0xa0/0x1a8)
>>> [   95.217111] [<c00d03ec>] (vfs_write) from [<c00d07f8>] (SyS_write+0x40/0x8c)
>>> [   95.224146] [<c00d07f8>] (SyS_write) from [<c000e660>] (ret_fast_syscall+0x0/0x48)
>>>
>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>> ---
>>>  drivers/gpu/drm/exynos/exynos_drm_crtc.c | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>>> index b68e58f..bde19f4 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>>> @@ -145,10 +145,16 @@ exynos_drm_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode,
>>>  	if (ret)
>>>  		return ret;
>>>  
>>> +	/* we need to unreference current fb after replacing it with new one */
>>> +	old_fb = plane->fb;
>>> +
>>>  	plane->crtc = crtc;
>>>  	plane->fb = crtc->primary->fb;
>>>  	drm_framebuffer_reference(plane->fb);
>>>  
>>> +	if (old_fb)
>>> +		drm_framebuffer_unreference(old_fb);
>> This time would be a good chance that we can consider drm flip queue to
>> make sure that whole memory region to old_fb is scanned out completely
>> before dropping a reference of old_fb. the reference of old_fb should be
>> dropped at irq handler of each crtc devices, fimd and mixer.
> Generally it's not a good idea to drop fb references from irq context,
> since if you actually drop the last reference it'll blow up: fb cleanup
> needs a bunch of mutexes.

I agree with that.

>
> Also the drm core really should be taking care of this for you, you only
> need to grab references yourself for async flips if you want the buffer to
> survive a bit. crtc_mode_set has not need for this. I expect that the
> refcounting bug is somewhere else, at least from my experience chasing
> such issues in i915 ;-)

Hmm, maybe I miss something but I do not see the core grabbing fb reference
on plane->fb update. On the other side drm_framebuffer_remove calls
drm_plane_force_disable which drops plane->fb reference.
I am not yet familiar with this code so maybe there is better solution.

If not I guess it would be better to move this code to
exynos_plane_mode_set.
At least it is done this way in omap and msm, in fact it seems better place
for such things. What do you think?

Regards
Andrzej

> -Daniel


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH 5/9] drm/exynos/crtc: fix framebuffer reference sequence
Date: Fri, 12 Sep 2014 11:27:41 +0200
Message-ID: <5412BC8D.2030007@samsung.com>
References: <1410268573-2297-1-git-send-email-a.hajda@samsung.com>
 <1410268573-2297-6-git-send-email-a.hajda@samsung.com>
 <5412B02A.6040609@samsung.com> <20140912085710.GD4740@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-reply-to: <20140912085710.GD4740@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Inki Dae <inki.dae@samsung.com>, "moderated list:ARM/S5P EXYNOS AR..." <linux-samsung-soc@vger.kernel.org>, Seung-Woo Kim <sw0312.kim@samsung.com>, open list <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, Kyungmin Park <kyungmin.park@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>
List-Id: linux-samsung-soc@vger.kernel.org

T24gMDkvMTIvMjAxNCAxMDo1NyBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBGcmksIFNl
cCAxMiwgMjAxNCBhdCAwNTozNDo1MFBNICswOTAwLCBJbmtpIERhZSB3cm90ZToKPj4gSGkgQW5k
cnplaiwKPj4KPj4gT24gMjAxNOuFhCAwOeyblCAwOeydvCAyMjoxNiwgQW5kcnplaiBIYWpkYSB3
cm90ZToKPj4+IEFkZGluZyByZWZlcmVuY2UgdG8gZnJhbWVidWZmZXIgc2hvdWxkIGJlIGFjY29t
cGFuaWVkIHdpdGggcmVtb3ZpbmcKPj4+IHJlZmVyZW5jZSB0byBvbGQgZnJhbWVidWZmZXIgYXNz
aWduZWQgdG8gdGhlIHBsYW5lLgo+Pj4gVGhpcyBwYXRjaCByZW1vdmVzIGZvbGxvd2luZyB3YXJu
aW5nOgo+Pj4KPj4+IFsgICA5NS4wMzgwMTddIFdBUk5JTkc6IENQVTogMSBQSUQ6IDMwNjcgYXQg
ZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmM6NTExNSBkcm1fbW9kZV9jb25maWdfY2xlYW51cCsw
eDI1OC8weDI2OCgpCj4+PiBbICAgOTUuMDQ4MDg2XSBNb2R1bGVzIGxpbmtlZCBpbjoKPj4+IFsg
ICA5NS4wNTE0MzBdIENQVTogMSBQSUQ6IDMwNjcgQ29tbTogYmFzaCBUYWludGVkOiBHICAgICAg
ICBXICAgICAgMy4xNi4wLTExMzU1LWc3YTZlY2E1LWRpcnR5ICMzMDE1Cj4+PiBbICAgOTUuMDYw
MDU4XSBbPGMwMDEzZTkwPl0gKHVud2luZF9iYWNrdHJhY2UpIGZyb20gWzxjMDAxMTEyOD5dIChz
aG93X3N0YWNrKzB4MTAvMHgxNCkKPj4+IFsgICA5NS4wNjc3NjZdIFs8YzAwMTExMjg+XSAoc2hv
d19zdGFjaykgZnJvbSBbPGMwNGE1ZGM0Pl0gKGR1bXBfc3RhY2srMHg3MC8weGJjKQo+Pj4gWyAg
IDk1LjA3NDk1M10gWzxjMDRhNWRjND5dIChkdW1wX3N0YWNrKSBmcm9tIFs8YzAwMjE3ODQ+XSAo
d2Fybl9zbG93cGF0aF9jb21tb24rMHg2NC8weDg4KQo+Pj4gWyAgIDk1LjA4MzAwNV0gWzxjMDAy
MTc4ND5dICh3YXJuX3Nsb3dwYXRoX2NvbW1vbikgZnJvbSBbPGMwMDIxN2M0Pl0gKHdhcm5fc2xv
d3BhdGhfbnVsbCsweDFjLzB4MjQpCj4+PiBbICAgOTUuMDkxNzgwXSBbPGMwMDIxN2M0Pl0gKHdh
cm5fc2xvd3BhdGhfbnVsbCkgZnJvbSBbPGMwMjc1ZmEwPl0gKGRybV9tb2RlX2NvbmZpZ19jbGVh
bnVwKzB4MjU4LzB4MjY4KQo+Pj4gWyAgIDk1LjEwMDk4M10gWzxjMDI3NWZhMD5dIChkcm1fbW9k
ZV9jb25maWdfY2xlYW51cCkgZnJvbSBbPGMwMjgxNzI0Pl0gKGV4eW5vc19kcm1fdW5sb2FkKzB4
MzgvMHg1MCkKPj4+IFsgICA5NS4xMDk5MTVdIFs8YzAyODE3MjQ+XSAoZXh5bm9zX2RybV91bmxv
YWQpIGZyb20gWzxjMDI2ZTI0OD5dIChkcm1fZGV2X3VucmVnaXN0ZXIrMHgyNC8weDk4KQo+Pj4g
WyAgIDk1LjExODQxNF0gWzxjMDI2ZTI0OD5dIChkcm1fZGV2X3VucmVnaXN0ZXIpIGZyb20gWzxj
MDI2ZWNiMD5dIChkcm1fcHV0X2RldisweDI4LzB4NjQpCj4+PiBbICAgOTUuMTI2NDEyXSBbPGMw
MjZlY2IwPl0gKGRybV9wdXRfZGV2KSBmcm9tIFs8YzAyOTQ3YzQ+XSAodGFrZV9kb3duX21hc3Rl
cisweDI0LzB4NDQpCj4+PiBbICAgOTUuMTM0MjE4XSBbPGMwMjk0N2M0Pl0gKHRha2VfZG93bl9t
YXN0ZXIpIGZyb20gWzxjMDI5NDg3MD5dIChjb21wb25lbnRfZGVsKzB4OGMvMHhjOCkKPj4+IFsg
ICA5NS4xNDIyMDFdIFs8YzAyOTQ4NzA+XSAoY29tcG9uZW50X2RlbCkgZnJvbSBbPGMwMjg2YzEw
Pl0gKGV4eW5vc19kc2lfcmVtb3ZlKzB4MTgvMHgyYykKPj4+IFsgICA5NS4xNTAyOTRdIFs8YzAy
ODZjMTA+XSAoZXh5bm9zX2RzaV9yZW1vdmUpIGZyb20gWzxjMDI5OWUwND5dIChwbGF0Zm9ybV9k
cnZfcmVtb3ZlKzB4MTgvMHgxYykKPj4+IFsgICA5NS4xNTg4NzJdIFs8YzAyOTllMDQ+XSAocGxh
dGZvcm1fZHJ2X3JlbW92ZSkgZnJvbSBbPGMwMjk4N2E0Pl0gKF9fZGV2aWNlX3JlbGVhc2VfZHJp
dmVyKzB4NzAvMHhjNCkKPj4+IFsgICA5NS4xNjc5ODFdIFs8YzAyOTg3YTQ+XSAoX19kZXZpY2Vf
cmVsZWFzZV9kcml2ZXIpIGZyb20gWzxjMDI5ODgxOD5dIChkZXZpY2VfcmVsZWFzZV9kcml2ZXIr
MHgyMC8weDJjKQo+Pj4gWyAgIDk1LjE3NzI2OF0gWzxjMDI5ODgxOD5dIChkZXZpY2VfcmVsZWFz
ZV9kcml2ZXIpIGZyb20gWzxjMDI5NzlkMD5dICh1bmJpbmRfc3RvcmUrMHg1Yy8weDk0KQo+Pj4g
WyAgIDk1LjE4NTU5N10gWzxjMDI5NzlkMD5dICh1bmJpbmRfc3RvcmUpIGZyb20gWzxjMDI5NzI3
OD5dIChkcnZfYXR0cl9zdG9yZSsweDIwLzB4MmMpCj4+PiBbICAgOTUuMTkzMzIzXSBbPGMwMjk3
Mjc4Pl0gKGRydl9hdHRyX3N0b3JlKSBmcm9tIFs8YzAxMmFhOTA+XSAoc3lzZnNfa2Zfd3JpdGUr
MHg0Yy8weDUwKQo+Pj4gWyAgIDk1LjIwMTIyNF0gWzxjMDEyYWE5MD5dIChzeXNmc19rZl93cml0
ZSkgZnJvbSBbPGMwMTI5ZTk0Pl0gKGtlcm5mc19mb3Bfd3JpdGUrMHhjNC8weDE4NCkKPj4+IFsg
ICA5NS4yMDkzOTNdIFs8YzAxMjllOTQ+XSAoa2VybmZzX2ZvcF93cml0ZSkgZnJvbSBbPGMwMGQw
M2VjPl0gKHZmc193cml0ZSsweGEwLzB4MWE4KQo+Pj4gWyAgIDk1LjIxNzExMV0gWzxjMDBkMDNl
Yz5dICh2ZnNfd3JpdGUpIGZyb20gWzxjMDBkMDdmOD5dIChTeVNfd3JpdGUrMHg0MC8weDhjKQo+
Pj4gWyAgIDk1LjIyNDE0Nl0gWzxjMDBkMDdmOD5dIChTeVNfd3JpdGUpIGZyb20gWzxjMDAwZTY2
MD5dIChyZXRfZmFzdF9zeXNjYWxsKzB4MC8weDQ4KQo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEFu
ZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3VuZy5jb20+Cj4+PiAtLS0KPj4+ICBkcml2ZXJzL2dw
dS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fY3J0Yy5jIHwgNiArKysrKysKPj4+ICAxIGZpbGUgY2hh
bmdlZCwgNiBpbnNlcnRpb25zKCspCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9leHlub3MvZXh5bm9zX2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5v
c19kcm1fY3J0Yy5jCj4+PiBpbmRleCBiNjhlNThmLi5iZGUxOWY0IDEwMDY0NAo+Pj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuYwo+Pj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuYwo+Pj4gQEAgLTE0NSwxMCArMTQ1LDE2
IEBAIGV4eW5vc19kcm1fY3J0Y19tb2RlX3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHN0cnVj
dCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+Pj4gIAlpZiAocmV0KQo+Pj4gIAkJcmV0dXJuIHJl
dDsKPj4+ICAKPj4+ICsJLyogd2UgbmVlZCB0byB1bnJlZmVyZW5jZSBjdXJyZW50IGZiIGFmdGVy
IHJlcGxhY2luZyBpdCB3aXRoIG5ldyBvbmUgKi8KPj4+ICsJb2xkX2ZiID0gcGxhbmUtPmZiOwo+
Pj4gKwo+Pj4gIAlwbGFuZS0+Y3J0YyA9IGNydGM7Cj4+PiAgCXBsYW5lLT5mYiA9IGNydGMtPnBy
aW1hcnktPmZiOwo+Pj4gIAlkcm1fZnJhbWVidWZmZXJfcmVmZXJlbmNlKHBsYW5lLT5mYik7Cj4+
PiAgCj4+PiArCWlmIChvbGRfZmIpCj4+PiArCQlkcm1fZnJhbWVidWZmZXJfdW5yZWZlcmVuY2Uo
b2xkX2ZiKTsKPj4gVGhpcyB0aW1lIHdvdWxkIGJlIGEgZ29vZCBjaGFuY2UgdGhhdCB3ZSBjYW4g
Y29uc2lkZXIgZHJtIGZsaXAgcXVldWUgdG8KPj4gbWFrZSBzdXJlIHRoYXQgd2hvbGUgbWVtb3J5
IHJlZ2lvbiB0byBvbGRfZmIgaXMgc2Nhbm5lZCBvdXQgY29tcGxldGVseQo+PiBiZWZvcmUgZHJv
cHBpbmcgYSByZWZlcmVuY2Ugb2Ygb2xkX2ZiLiB0aGUgcmVmZXJlbmNlIG9mIG9sZF9mYiBzaG91
bGQgYmUKPj4gZHJvcHBlZCBhdCBpcnEgaGFuZGxlciBvZiBlYWNoIGNydGMgZGV2aWNlcywgZmlt
ZCBhbmQgbWl4ZXIuCj4gR2VuZXJhbGx5IGl0J3Mgbm90IGEgZ29vZCBpZGVhIHRvIGRyb3AgZmIg
cmVmZXJlbmNlcyBmcm9tIGlycSBjb250ZXh0LAo+IHNpbmNlIGlmIHlvdSBhY3R1YWxseSBkcm9w
IHRoZSBsYXN0IHJlZmVyZW5jZSBpdCdsbCBibG93IHVwOiBmYiBjbGVhbnVwCj4gbmVlZHMgYSBi
dW5jaCBvZiBtdXRleGVzLgoKSSBhZ3JlZSB3aXRoIHRoYXQuCgo+Cj4gQWxzbyB0aGUgZHJtIGNv
cmUgcmVhbGx5IHNob3VsZCBiZSB0YWtpbmcgY2FyZSBvZiB0aGlzIGZvciB5b3UsIHlvdSBvbmx5
Cj4gbmVlZCB0byBncmFiIHJlZmVyZW5jZXMgeW91cnNlbGYgZm9yIGFzeW5jIGZsaXBzIGlmIHlv
dSB3YW50IHRoZSBidWZmZXIgdG8KPiBzdXJ2aXZlIGEgYml0LiBjcnRjX21vZGVfc2V0IGhhcyBu
b3QgbmVlZCBmb3IgdGhpcy4gSSBleHBlY3QgdGhhdCB0aGUKPiByZWZjb3VudGluZyBidWcgaXMg
c29tZXdoZXJlIGVsc2UsIGF0IGxlYXN0IGZyb20gbXkgZXhwZXJpZW5jZSBjaGFzaW5nCj4gc3Vj
aCBpc3N1ZXMgaW4gaTkxNSA7LSkKCkhtbSwgbWF5YmUgSSBtaXNzIHNvbWV0aGluZyBidXQgSSBk
byBub3Qgc2VlIHRoZSBjb3JlIGdyYWJiaW5nIGZiIHJlZmVyZW5jZQpvbiBwbGFuZS0+ZmIgdXBk
YXRlLiBPbiB0aGUgb3RoZXIgc2lkZSBkcm1fZnJhbWVidWZmZXJfcmVtb3ZlIGNhbGxzCmRybV9w
bGFuZV9mb3JjZV9kaXNhYmxlIHdoaWNoIGRyb3BzIHBsYW5lLT5mYiByZWZlcmVuY2UuCkkgYW0g
bm90IHlldCBmYW1pbGlhciB3aXRoIHRoaXMgY29kZSBzbyBtYXliZSB0aGVyZSBpcyBiZXR0ZXIg
c29sdXRpb24uCgpJZiBub3QgSSBndWVzcyBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gbW92ZSB0aGlz
IGNvZGUgdG8KZXh5bm9zX3BsYW5lX21vZGVfc2V0LgpBdCBsZWFzdCBpdCBpcyBkb25lIHRoaXMg
d2F5IGluIG9tYXAgYW5kIG1zbSwgaW4gZmFjdCBpdCBzZWVtcyBiZXR0ZXIgcGxhY2UKZm9yIHN1
Y2ggdGhpbmdzLiBXaGF0IGRvIHlvdSB0aGluaz8KClJlZ2FyZHMKQW5kcnplagoKPiAtRGFuaWVs
CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2
ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=