From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [XEN/ARM PATCH v1 1/1] Unbreak Arndale XEN boot Date: Fri, 12 Sep 2014 11:39:17 -0700 Message-ID: <54133DD5.9050003@linaro.org> References: <1410456310-31415-1-git-send-email-suriyan.r@gmail.com> <5411EEC2.7050108@linaro.org> <1410516506.567.44.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suriyan Ramasami , Ian Campbell Cc: keir@xen.org, Tim Deegan , "xen-devel@lists.xen.org" , Jan Beulich , ian.jackson@citrix.com, Julien Grall List-Id: xen-devel@lists.xenproject.org Hi Suriyan, On 12/09/14 10:50, Suriyan Ramasami wrote: >> A few procedural comments: >> >> Please use "git format-patch" (or even git send-email) and not "git >> show" to export the patch for sending, this will remove the unnecessary >> indent. >> > I actually use git format-patch to generate the patch, and I do edit > some of the comments in that patch file, before I use git send-email. > Can you please give me an example of the "unnecessary indent" that > you mention, so I can check what I am doing wrong. Each beginning of your commit message lines start by an indent. git format-patch should drop it by default. Current you have smth like: foo base This should be: foo base > >> The email's subject line will be included into the commit message, so no >> need to repeat it in the body. "git format-patch" will do the right >> thing. >> >> "Changes between versions" stuff should come after your S-o-b and a >> "---" (on a line of its own) marker, which means that they won't get >> included in the commit message. >> > Sorry about that. I did know that part (has been repeatedly mentioned > before). It was a mistake on my part, while editing the output of > format-patch, I manually copy and paste the version changes that I am > doing, and this time around I pasted it before the S-o-b. Is that not > the right approach? The S-o-b can be generated directly when you generate the commit (git commit -s ...). For the changes you can also add in your commit message directly. So you should not need to modify the patch generated by git format-patch. Regards, -- Julien Grall