From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [XEN/ARM PATCH v1 1/1] Unbreak Arndale XEN boot
Date: Fri, 12 Sep 2014 14:07:23 -0700
Message-ID: <5413608B.6080504@linaro.org>
References: <1410456310-31415-1-git-send-email-suriyan.r@gmail.com>	<5411EEC2.7050108@linaro.org>	<CANoR_ODd5=kRfQbJGP=GDpUxTRE1noKeZ_mukpW4Y_yqab02XA@mail.gmail.com>	<5413426B.6010801@linaro.org>	<CANoR_OD1+zwrc3V4TBhx+QoTELOMMLw-xbr+pLgLAnUa_8qwtg@mail.gmail.com>
	<CANoR_OD-xjGSarHea=r+1=_ahbnfOqbMurvvAc-vU-fcyVFzbA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CANoR_OD-xjGSarHea=r+1=_ahbnfOqbMurvvAc-vU-fcyVFzbA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Suriyan Ramasami <suriyan.r@gmail.com>
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, ian.jackson@citrix.com, Julien Grall <julien.grall@linaro.com>
List-Id: xen-devel@lists.xenproject.org

On 12/09/14 14:03, Suriyan Ramasami wrote:
> On Fri, Sep 12, 2014 at 12:34 PM, Suriyan Ramasami <suriyan.r@gmail.com> wrote:
>> On Fri, Sep 12, 2014 at 11:58 AM, Julien Grall <julien.grall@linaro.org> wrote:
>>> Hi Suriyan,
>>>
>>> A couple of remarks about the Samsung secure firmware and your patch.
>>>
>>> When secure firmware is present, the CPU bring up is done by SMC (I don't
>>> see this code in your patch).
>>>
>> Yes you are right. A call to call_firmware_op(cpu_boot, phys_cpu)
>> translating to exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0) is missing
>> right before the call to waking up the  cpu.
>> This was intentional on my part as the trustzone blob that comes with
>> the odroid xu does not have code for that smc call and just returns
>> -1.
>>
>>   I am guessing as we want this as generic as posisble, I should add
>> that part in.
>>
>>> Also, for now, the secure firmware MMIO range is mapped to DOM0. I'm not
>>> sure we should do that because it contains way to idle CPU...
>>> I think we should blacklist it for now. And see how DOM0 behave without.
>>>
>> I shall try this on the Odroid XU.
>>
>
> Hello Julien,

Hello Suriyan,

>     I blacklisted "samsung,secure-firmware" and I can't perceive any
> change in DOM0's behavior in the Odroid XU. Do you recommend, I send
> the next patch with this blacklisted?

Yes please.

Regards,

-- 
Julien Grall