From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Masters Subject: Re: [PATCH v4 05/18] ARM64 / ACPI: Introduce sleep-arm.c Date: Fri, 12 Sep 2014 17:10:32 -0400 Message-ID: <54136148.40106@redhat.com> References: <1410530416-30200-1-git-send-email-hanjun.guo@linaro.org> <1410530416-30200-6-git-send-email-hanjun.guo@linaro.org> <54134CE8.8070506@redhat.com> <20140912200355.GD9234@xora-haswell.xora.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbaILVL6 (ORCPT ); Fri, 12 Sep 2014 17:11:58 -0400 In-Reply-To: <20140912200355.GD9234@xora-haswell.xora.org.uk> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Graeme Gregory Cc: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , Grant Likely , Will Deacon , Rob Herring , Lorenzo Pieralisi , Robert Richter , Jason Cooper , Arnd Bergmann , linaro-acpi@lists.linaro.org, Marc Zyngier , Daniel Lezcano , Liviu Dudau , Robert Moore , Tomasz Nowicki , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Brown , Randy Dunlap , Lv Zheng , Sudeep Holla , Bjo On 09/12/2014 04:03 PM, Graeme Gregory wrote: > On Fri, Sep 12, 2014 at 03:43:36PM -0400, Jon Masters wrote: >> On 09/12/2014 10:00 AM, Hanjun Guo wrote: >>> From: Graeme Gregory >>> >>> ACPI 5.1 does not currently support S states for ARM64 hardware but >>> ACPI code will call acpi_target_system_state() for device power >>> managment, so introduce sleep-arm.c to allow other drivers to function >>> until S states are defined. >> >> Aside: ACPI5.1 does define the Platform Communication Channel and CPC >> (Collaborative Processor Performance Control). Some details need to be >> fleshed out there for practical 64-bit ARMv8 server systems, but the >> underpinnings and mechanisms are in place in the 5.1 specification that >> can be built upon over time to achieve practical S-State equivalence. ^ meant C/P sorry > Disagree, S-States are about going to sleep or hibernating, that is > nothing to do with CPU Performance. Correct. In replying to the above, I was thinking about power and performance management of components - CPU (C/P), and device (D) specific power/performance states - not the overall system (S) state, and I went off on a tangent. That was off-topic. For the actual topic at hand, that of global sleep, you are correct that only G0 (S0) and S5 are really defined today. Though I do think that the PCC might be used to actually implement overall system sleep state transitions later. Jon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbaILVMB (ORCPT ); Fri, 12 Sep 2014 17:12:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbaILVL6 (ORCPT ); Fri, 12 Sep 2014 17:11:58 -0400 Message-ID: <54136148.40106@redhat.com> Date: Fri, 12 Sep 2014 17:10:32 -0400 From: Jon Masters Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Graeme Gregory CC: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , Grant Likely , Will Deacon , Rob Herring , Lorenzo Pieralisi , Robert Richter , Jason Cooper , Arnd Bergmann , linaro-acpi@lists.linaro.org, Marc Zyngier , Daniel Lezcano , Liviu Dudau , Robert Moore , Tomasz Nowicki , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Brown , Randy Dunlap , Lv Zheng , Sudeep Holla , Bjorn Helgaas , Graeme Gregory , linux-arm-kernel@lists.infradead.org, Charles.Garcia-Tobin@arm.com Subject: Re: [PATCH v4 05/18] ARM64 / ACPI: Introduce sleep-arm.c References: <1410530416-30200-1-git-send-email-hanjun.guo@linaro.org> <1410530416-30200-6-git-send-email-hanjun.guo@linaro.org> <54134CE8.8070506@redhat.com> <20140912200355.GD9234@xora-haswell.xora.org.uk> In-Reply-To: <20140912200355.GD9234@xora-haswell.xora.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2014 04:03 PM, Graeme Gregory wrote: > On Fri, Sep 12, 2014 at 03:43:36PM -0400, Jon Masters wrote: >> On 09/12/2014 10:00 AM, Hanjun Guo wrote: >>> From: Graeme Gregory >>> >>> ACPI 5.1 does not currently support S states for ARM64 hardware but >>> ACPI code will call acpi_target_system_state() for device power >>> managment, so introduce sleep-arm.c to allow other drivers to function >>> until S states are defined. >> >> Aside: ACPI5.1 does define the Platform Communication Channel and CPC >> (Collaborative Processor Performance Control). Some details need to be >> fleshed out there for practical 64-bit ARMv8 server systems, but the >> underpinnings and mechanisms are in place in the 5.1 specification that >> can be built upon over time to achieve practical S-State equivalence. ^ meant C/P sorry > Disagree, S-States are about going to sleep or hibernating, that is > nothing to do with CPU Performance. Correct. In replying to the above, I was thinking about power and performance management of components - CPU (C/P), and device (D) specific power/performance states - not the overall system (S) state, and I went off on a tangent. That was off-topic. For the actual topic at hand, that of global sleep, you are correct that only G0 (S0) and S5 are really defined today. Though I do think that the PCC might be used to actually implement overall system sleep state transitions later. Jon. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jcm@redhat.com (Jon Masters) Date: Fri, 12 Sep 2014 17:10:32 -0400 Subject: [PATCH v4 05/18] ARM64 / ACPI: Introduce sleep-arm.c In-Reply-To: <20140912200355.GD9234@xora-haswell.xora.org.uk> References: <1410530416-30200-1-git-send-email-hanjun.guo@linaro.org> <1410530416-30200-6-git-send-email-hanjun.guo@linaro.org> <54134CE8.8070506@redhat.com> <20140912200355.GD9234@xora-haswell.xora.org.uk> Message-ID: <54136148.40106@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/12/2014 04:03 PM, Graeme Gregory wrote: > On Fri, Sep 12, 2014 at 03:43:36PM -0400, Jon Masters wrote: >> On 09/12/2014 10:00 AM, Hanjun Guo wrote: >>> From: Graeme Gregory >>> >>> ACPI 5.1 does not currently support S states for ARM64 hardware but >>> ACPI code will call acpi_target_system_state() for device power >>> managment, so introduce sleep-arm.c to allow other drivers to function >>> until S states are defined. >> >> Aside: ACPI5.1 does define the Platform Communication Channel and CPC >> (Collaborative Processor Performance Control). Some details need to be >> fleshed out there for practical 64-bit ARMv8 server systems, but the >> underpinnings and mechanisms are in place in the 5.1 specification that >> can be built upon over time to achieve practical S-State equivalence. ^ meant C/P sorry > Disagree, S-States are about going to sleep or hibernating, that is > nothing to do with CPU Performance. Correct. In replying to the above, I was thinking about power and performance management of components - CPU (C/P), and device (D) specific power/performance states - not the overall system (S) state, and I went off on a tangent. That was off-topic. For the actual topic at hand, that of global sleep, you are correct that only G0 (S0) and S5 are really defined today. Though I do think that the PCC might be used to actually implement overall system sleep state transitions later. Jon.