* [cip-dev][isar-cip-core][PATCH] scripts/wic/efibootguard-boot: Add missing whitespace
@ 2021-09-27 8:38 ` Quirin Gylstorff
0 siblings, 0 replies; 4+ messages in thread
From: Q. Gylstorff @ 2021-09-27 8:38 UTC (permalink / raw)
To: cip-dev; +Cc: Quirin Gylstorff
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
The generated Kernel commandline was incorrect concatenated.
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
scripts/lib/wic/plugins/source/efibootguard-boot.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
index b85cfca..882729a 100644
--- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
+++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
@@ -99,7 +99,7 @@ class EfibootguardBootPlugin(SourcePlugin):
exit(1)
root_dev = root_dev.replace(":", "=")
- cmdline += " root=%s rw" % root_dev
+ cmdline += " root=%s rw " % root_dev
boot_files.append(kernel_image)
boot_files.append(initrd_image)
cmdline += "initrd=%s" % initrd_image if initrd_image else ""
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [cip-dev][isar-cip-core][PATCH] scripts/wic/efibootguard-boot: Add missing whitespace
@ 2021-09-27 8:38 ` Quirin Gylstorff
0 siblings, 0 replies; 4+ messages in thread
From: Quirin Gylstorff @ 2021-09-27 8:38 UTC (permalink / raw)
To: cip-dev; +Cc: Quirin Gylstorff
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
The generated Kernel commandline was incorrect concatenated.
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
scripts/lib/wic/plugins/source/efibootguard-boot.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
index b85cfca..882729a 100644
--- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
+++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
@@ -99,7 +99,7 @@ class EfibootguardBootPlugin(SourcePlugin):
exit(1)
root_dev = root_dev.replace(":", "=")
- cmdline += " root=%s rw" % root_dev
+ cmdline += " root=%s rw " % root_dev
boot_files.append(kernel_image)
boot_files.append(initrd_image)
cmdline += "initrd=%s" % initrd_image if initrd_image else ""
--
2.30.2
[-- Attachment #2: Type: text/plain, Size: 429 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6750): https://lists.cip-project.org/g/cip-dev/message/6750
Mute This Topic: https://lists.cip-project.org/mt/85895818/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cip-dev][isar-cip-core][PATCH] scripts/wic/efibootguard-boot: Add missing whitespace
@ 2021-10-06 17:42 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2021-10-06 17:42 UTC (permalink / raw)
To: Q. Gylstorff, cip-dev
On 27.09.21 10:38, Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> The generated Kernel commandline was incorrect concatenated.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> scripts/lib/wic/plugins/source/efibootguard-boot.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> index b85cfca..882729a 100644
> --- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
> +++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> @@ -99,7 +99,7 @@ class EfibootguardBootPlugin(SourcePlugin):
> exit(1)
> root_dev = root_dev.replace(":", "=")
>
> - cmdline += " root=%s rw" % root_dev
> + cmdline += " root=%s rw " % root_dev
> boot_files.append(kernel_image)
> boot_files.append(initrd_image)
> cmdline += "initrd=%s" % initrd_image if initrd_image else ""
>
Thanks, applied.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev][isar-cip-core][PATCH] scripts/wic/efibootguard-boot: Add missing whitespace
@ 2021-10-06 17:42 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2021-10-06 17:42 UTC (permalink / raw)
To: Q. Gylstorff, cip-dev
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On 27.09.21 10:38, Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> The generated Kernel commandline was incorrect concatenated.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> scripts/lib/wic/plugins/source/efibootguard-boot.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> index b85cfca..882729a 100644
> --- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
> +++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> @@ -99,7 +99,7 @@ class EfibootguardBootPlugin(SourcePlugin):
> exit(1)
> root_dev = root_dev.replace(":", "=")
>
> - cmdline += " root=%s rw" % root_dev
> + cmdline += " root=%s rw " % root_dev
> boot_files.append(kernel_image)
> boot_files.append(initrd_image)
> cmdline += "initrd=%s" % initrd_image if initrd_image else ""
>
Thanks, applied.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
[-- Attachment #2: Type: text/plain, Size: 429 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6794): https://lists.cip-project.org/g/cip-dev/message/6794
Mute This Topic: https://lists.cip-project.org/mt/85895818/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-06 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 8:38 [cip-dev][isar-cip-core][PATCH] scripts/wic/efibootguard-boot: Add missing whitespace Q. Gylstorff
2021-09-27 8:38 ` Quirin Gylstorff
2021-10-06 17:42 ` Jan Kiszka
2021-10-06 17:42 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.