From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XStL0-0006C4-8H
	for qemu-devel@nongnu.org; Sat, 13 Sep 2014 15:50:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XStKr-0005Jh-70
	for qemu-devel@nongnu.org; Sat, 13 Sep 2014 15:50:26 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:36093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XStKr-0005Jb-0D
	for qemu-devel@nongnu.org; Sat, 13 Sep 2014 15:50:17 -0400
Received: by mail-wg0-f52.google.com with SMTP id x13so2192477wgg.35
	for <qemu-devel@nongnu.org>; Sat, 13 Sep 2014 12:50:16 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54149FF3.2080301@redhat.com>
Date: Sat, 13 Sep 2014 21:50:11 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410582855-21870-1-git-send-email-jsnow@redhat.com>	<1410582855-21870-4-git-send-email-jsnow@redhat.com>
	<541445F8.7080909@redhat.com>
In-Reply-To: <541445F8.7080909@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, mst@redhat.com

Il 13/09/2014 15:26, Paolo Bonzini ha scritto:
>> >  
>> > +    if (ad->dp_intr_req) {
>> > +        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE);
>> > +        ad->dp_intr_req = 0;
>> > +    }
> Is it also needed in the error case?  Especially the short-PRDT case
> that you are adding in the next patch.
> 

... and is it also needed for NCQ, albeit with a separate flag?

Paolo