* [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly
@ 2014-09-11 8:55 Subbaraya Sundeep Bhatta
2014-09-12 17:25 ` Lars-Peter Clausen
0 siblings, 1 reply; 6+ messages in thread
From: Subbaraya Sundeep Bhatta @ 2014-09-11 8:55 UTC (permalink / raw)
To: jic23, lars, linux-iio, linux-kernel
Cc: michals, svemula, anirudh, Subbaraya Sundeep Bhatta
This patch fixes incorrect logic for assigning address
to auxiliary channels of xilinx xadc.
Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
---
drivers/iio/adc/xilinx-xadc-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index fd2745c..626b397 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1126,7 +1126,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np,
chan->address = XADC_REG_VPVN;
} else {
chan->scan_index = 15 + reg;
- chan->scan_index = XADC_REG_VAUX(reg - 1);
+ chan->address = XADC_REG_VAUX(reg - 1);
}
num_channels++;
chan++;
--
1.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly
2014-09-11 8:55 [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly Subbaraya Sundeep Bhatta
@ 2014-09-12 17:25 ` Lars-Peter Clausen
2014-09-13 20:04 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2014-09-12 17:25 UTC (permalink / raw)
To: Subbaraya Sundeep Bhatta, jic23, linux-iio, linux-kernel
Cc: michals, svemula, anirudh, Subbaraya Sundeep Bhatta
On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
> This patch fixes incorrect logic for assigning address
> to auxiliary channels of xilinx xadc.
>
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index fd2745c..626b397 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1126,7 +1126,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np,
> chan->address = XADC_REG_VPVN;
> } else {
> chan->scan_index = 15 + reg;
> - chan->scan_index = XADC_REG_VAUX(reg - 1);
> + chan->address = XADC_REG_VAUX(reg - 1);
> }
> num_channels++;
> chan++;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly
2014-09-12 17:25 ` Lars-Peter Clausen
@ 2014-09-13 20:04 ` Jonathan Cameron
2014-09-14 8:30 ` sundeep subbaraya
2014-10-03 22:34 ` iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly) Anssi Hannula
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Cameron @ 2014-09-13 20:04 UTC (permalink / raw)
To: Lars-Peter Clausen, Subbaraya Sundeep Bhatta, linux-iio, linux-kernel
Cc: michals, svemula, anirudh, Subbaraya Sundeep Bhatta
On 12/09/14 18:25, Lars-Peter Clausen wrote:
> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>> This patch fixes incorrect logic for assigning address
>> to auxiliary channels of xilinx xadc.
>>
>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the fixes-togreg branch of iio.git and flagged
for stable.
Thanks,
Jonathan
>
>> ---
>> drivers/iio/adc/xilinx-xadc-core.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
>> index fd2745c..626b397 100644
>> --- a/drivers/iio/adc/xilinx-xadc-core.c
>> +++ b/drivers/iio/adc/xilinx-xadc-core.c
>> @@ -1126,7 +1126,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np,
>> chan->address = XADC_REG_VPVN;
>> } else {
>> chan->scan_index = 15 + reg;
>> - chan->scan_index = XADC_REG_VAUX(reg - 1);
>> + chan->address = XADC_REG_VAUX(reg - 1);
>> }
>> num_channels++;
>> chan++;
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly
2014-09-13 20:04 ` Jonathan Cameron
@ 2014-09-14 8:30 ` sundeep subbaraya
2014-10-03 22:34 ` iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly) Anssi Hannula
1 sibling, 0 replies; 6+ messages in thread
From: sundeep subbaraya @ 2014-09-14 8:30 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Subbaraya Sundeep Bhatta, linux-iio,
linux-kernel, Michal Simek, svemula, anirudh,
Subbaraya Sundeep Bhatta
Thanks Lars and Jonathan,
Sundeep.
On Sun, Sep 14, 2014 at 1:34 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 12/09/14 18:25, Lars-Peter Clausen wrote:
>> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>>> This patch fixes incorrect logic for assigning address
>>> to auxiliary channels of xilinx xadc.
>>>
>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Applied to the fixes-togreg branch of iio.git and flagged
> for stable.
>
> Thanks,
>
> Jonathan
>>
>>> ---
>>> drivers/iio/adc/xilinx-xadc-core.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
>>> index fd2745c..626b397 100644
>>> --- a/drivers/iio/adc/xilinx-xadc-core.c
>>> +++ b/drivers/iio/adc/xilinx-xadc-core.c
>>> @@ -1126,7 +1126,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np,
>>> chan->address = XADC_REG_VPVN;
>>> } else {
>>> chan->scan_index = 15 + reg;
>>> - chan->scan_index = XADC_REG_VAUX(reg - 1);
>>> + chan->address = XADC_REG_VAUX(reg - 1);
>>> }
>>> num_channels++;
>>> chan++;
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly)
2014-09-13 20:04 ` Jonathan Cameron
2014-09-14 8:30 ` sundeep subbaraya
@ 2014-10-03 22:34 ` Anssi Hannula
2014-10-04 10:17 ` iio commit dates in future Jonathan Cameron
1 sibling, 1 reply; 6+ messages in thread
From: Anssi Hannula @ 2014-10-03 22:34 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Subbaraya Sundeep Bhatta, linux-iio,
linux-kernel, stable
13.09.2014, 23:04, Jonathan Cameron kirjoitti:
> On 12/09/14 18:25, Lars-Peter Clausen wrote:
>> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>>> This patch fixes incorrect logic for assigning address
>>> to auxiliary channels of xilinx xadc.
>>>
>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Applied to the fixes-togreg branch of iio.git and flagged
> for stable.
Something weird seems to have happened with this commit and at least a
few others:
1887e724e2 "iio: adc: xilinx-xadc: assign auxiliary channels address
correctly"
d4f51956ac "iio: adc: at91: don't use the last converted data register"
a31d092899 "iio:magnetometer: bugfix magnetometers gain values".
They all have their Date in the future (up to Nov 2014), looks to me
like month and day got swapped for some reason.
Not a big issue I guess, but worth looking into if it is something in
your workflow causing this :)
Noticed these strange Dates while looking at Greg's stable-queue repo.
--
Anssi Hannula
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iio commit dates in future
2014-10-03 22:34 ` iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly) Anssi Hannula
@ 2014-10-04 10:17 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2014-10-04 10:17 UTC (permalink / raw)
To: Anssi Hannula
Cc: Lars-Peter Clausen, Subbaraya Sundeep Bhatta, linux-iio,
linux-kernel, stable
On 03/10/14 23:34, Anssi Hannula wrote:
> 13.09.2014, 23:04, Jonathan Cameron kirjoitti:
>> On 12/09/14 18:25, Lars-Peter Clausen wrote:
>>> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>>>> This patch fixes incorrect logic for assigning address
>>>> to auxiliary channels of xilinx xadc.
>>>>
>>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>>>
>>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>> Applied to the fixes-togreg branch of iio.git and flagged
>> for stable.
>
> Something weird seems to have happened with this commit and at least a
> few others:
> 1887e724e2 "iio: adc: xilinx-xadc: assign auxiliary channels address
> correctly"
> d4f51956ac "iio: adc: at91: don't use the last converted data register"
> a31d092899 "iio:magnetometer: bugfix magnetometers gain values".
>
> They all have their Date in the future (up to Nov 2014), looks to me
> like month and day got swapped for some reason.
>
> Not a big issue I guess, but worth looking into if it is something in
> your workflow causing this :)
>
> Noticed these strange Dates while looking at Greg's stable-queue repo.
>
I have a suspicion that this is to do with the fact I use thunderbird to
manage my email and save it out as plain text. I'm using the import
export tools package on top of thunderbird (as it gives a cleaner result)
but it is using numeric dates. Which git am is happy with, but apparently
it isn't coping well with American date formats vs mine. Superficially
looks like this is fine if I use the much more verbose alternative of
saving as an eml file and using that...
There are some dates that have by coincidence jumped a fair way back into
the past as well.
I did notice an incidence of this a few months back but thought it was just
a one off. Thanks for bringing it up Anssi!
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-04 10:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-11 8:55 [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly Subbaraya Sundeep Bhatta
2014-09-12 17:25 ` Lars-Peter Clausen
2014-09-13 20:04 ` Jonathan Cameron
2014-09-14 8:30 ` sundeep subbaraya
2014-10-03 22:34 ` iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly) Anssi Hannula
2014-10-04 10:17 ` iio commit dates in future Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.