From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756534AbaIPB0F (ORCPT ); Mon, 15 Sep 2014 21:26:05 -0400 Received: from imx9.toshiba.co.jp ([202.33.96.51]:62980 "EHLO imx9.toshiba.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbaIPB0C (ORCPT ); Mon, 15 Sep 2014 21:26:02 -0400 X-Greylist: delayed 1673 seconds by postgrey-1.27 at vger.kernel.org; Mon, 15 Sep 2014 21:26:01 EDT From: To: , CC: , , , , Subject: Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards Thread-Topic: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards Thread-Index: AQHPzClihiT9qP4CC02kQYp4vcc1opv6o8KAgAbHH4CAAAn4AIAAAqSAgAAJ2QCAAOC+gA== Date: Tue, 16 Sep 2014 00:53:34 +0000 Message-ID: <54178A0D.1050004@toshiba.co.jp> References: <1410265614-3275-1-git-send-email-jean-michel.hautbois@vodalys.com> <54110B29.7030303@samsung.com> <5416C30C.6010400@samsung.com> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: en-US user-agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 x-originating-ip: [133.199.145.187] msscp.transfermailtomossagent: 103 Content-Type: text/plain; charset="utf-8" Content-ID: <67135EB60333E5478C9A6E1CF358AD93@toshiba.local> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8G1QB9G024222 Hi Do not hit the following bug? Often, This bug fails setting of CMD6. -------- Original Message -------- Subject: Re: [PATCH v2] mmc:sdhci: handle busy-end interrupt during command Date: Tue, 2 Sep 2014 11:27:51 +0200 From: Ulf Hansson To: Chanho Min On 30 August 2014 05:40, Chanho Min wrote: > It is fully legal for a controller to start handling busy-end interrupt > before it has signaled that the command has completed. So make sure > we do things in the proper order, Or it results that command interrupt > is ignored so it can cause unexpected operations. This is founded at some > toshiba emmc with the bellow warning. > > "mmc0: Got command interrupt 0x00000001 even though > no command operation was in progress." > > This issue has been also reported by Youssef TRIKI: > It is not specific to Toshiba devices, and happens with eMMC devices > as well as SD card which support Auto-CMD12 rather than CMD23. > > Also, similar patch is submitted by: > Gwendal Grignou > > Changes since v1: > Fixed conflict with the next of git.linaro.org/people/ulf.hansson/mmc.git > and Tested if issue is fixed again. > > Signed-off-by: Hankyung Yu > Signed-off-by: Chanho Min > Tested-by: Youssef TRIKI Best Regards, ======================================================= Hisanao Kinkawa [hisanao.kinkawa@toshiba.co.jp ] ======================================================= (2014/09/15 20:29), Jean-Michel Hautbois wrote: > 2014-09-15 12:53 GMT+02:00 Jean-Michel Hautbois > : >> 2014-09-15 12:44 GMT+02:00 Jaehoon Chung : >>> On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote: >>>> Hi Jaehoon, >>>> >>>>> On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote: >>>>>> Tested on a i.MX6 board, with Sandisk SDIN5D1-2G. >>>>>> Without this patch, I/O errors occur. >>>>>> This eMMC seems to have a different Manufacturer ID as it reads 0x45 >>>>>> and not 0x2 as specified in datasheet. >>>>> I think this patch don't merge into mainline. >>>>> This is not solution for problem. >>>>> you mentioned the below comment, this is workaround. >>>> Yes >>>> >>>>>> Signed-off-by: Jean-Michel Hautbois >>>>>> --- >>>>>> drivers/mmc/core/mmc_ops.c | 9 +++++++++ >>>>>> 1 file changed, 9 insertions(+) >>>>>> >>>>>> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c >>>>>> index f51b5ba..91babaa 100644 >>>>>> --- a/drivers/mmc/core/mmc_ops.c >>>>>> +++ b/drivers/mmc/core/mmc_ops.c >>>>>> @@ -458,6 +458,15 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, >>>>>> if (!use_busy_signal) >>>>>> return 0; >>>>>> >>>>>> + /* WORKAROUND: for Sandisk eMMC cards, it might need certain delay >>>>>> + * before sending CMD13 after CMD6 >>>>>> + * On SDIN5D1-2G MANFID is 0x45 and not 0x2 as specified in datasheet >>>>>> + */ >>>>>> + if (card->cid.manfid == CID_MANFID_SANDISK || >>>>>> + card->cid.manfid == 0x45) { >>>>>> + msleep(1); >>>>>> + } >>>>> If it's a general problem of Sandisk SDIN5D1-2G, >>>>> I think you need to verify this problem. And can you use the MMC_FIXUP() and QUIRK? >>>> Well, this is difficult to verify, I know that on all my SDIN5D1-2G I >>>> have this MANFID different from what is defined by CID_MANFID_SANDISK. >>>> How should I use MMC_FIXUP ? Like this ? >>> I think you need to explain why delay is need. >>> i didn't have same card, but it might be your host controller or other problem. >> Well, I don't know why it is needed, this is undocumented, nothing in >> datasheet explains anything about this. > It seems to be uSDHC / DDR mode related. I don't even know if this is > limited to Sandisk ! > And I don't have another board with another manufacturer eMMC to test. > Maybe some guys from Freescale could help with this ? > > Thanks, > JM > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > . > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards Date: Tue, 16 Sep 2014 00:53:34 +0000 Message-ID: <54178A0D.1050004@toshiba.co.jp> References: <1410265614-3275-1-git-send-email-jean-michel.hautbois@vodalys.com> <54110B29.7030303@samsung.com> <5416C30C.6010400@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from imx9.toshiba.co.jp ([202.33.96.51]:62980 "EHLO imx9.toshiba.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbaIPB0C (ORCPT ); Mon, 15 Sep 2014 21:26:02 -0400 In-Reply-To: Content-Language: en-US Content-ID: <67135EB60333E5478C9A6E1CF358AD93@toshiba.local> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: jean-michel.hautbois@vodalys.com, jh80.chung@samsung.com Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, tgih.jun@samsung.com, ulf.hansson@linaro.org, chris@printf.net SGkNCg0KRG8gbm90IGhpdCB0aGUgZm9sbG93aW5nIGJ1Zz8NCk9mdGVuLCBUaGlzIGJ1ZyBmYWls cyBzZXR0aW5nIG9mIENNRDYuDQoNCi0tLS0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0tLS0N ClN1YmplY3Q6IAlSZTogW1BBVENIIHYyXSBtbWM6c2RoY2k6IGhhbmRsZSBidXN5LWVuZCBpbnRl cnJ1cHQgZHVyaW5nIGNvbW1hbmQNCkRhdGU6IAlUdWUsIDIgU2VwIDIwMTQgMTE6Mjc6NTEgKzAy MDANCkZyb206IAlVbGYgSGFuc3NvbiA8dWxmLmhhbnNzb25AbGluYXJvLm9yZz4NClRvOiAJQ2hh bmhvIE1pbiA8Y2hhbmhvLm1pbkBsZ2UuY29tPg0KDQoJDQoNCk9uIDMwIEF1Z3VzdCAyMDE0IDA1 OjQwLCBDaGFuaG8gTWluIDxjaGFuaG8ubWluQGxnZS5jb20+IHdyb3RlOg0KPiBJdCBpcyBmdWxs eSBsZWdhbCBmb3IgYSBjb250cm9sbGVyIHRvIHN0YXJ0IGhhbmRsaW5nIGJ1c3ktZW5kIGludGVy cnVwdA0KPiBiZWZvcmUgaXQgaGFzIHNpZ25hbGVkIHRoYXQgdGhlIGNvbW1hbmQgaGFzIGNvbXBs ZXRlZC4gU28gbWFrZSBzdXJlDQo+IHdlIGRvIHRoaW5ncyBpbiB0aGUgcHJvcGVyIG9yZGVyLCBP ciBpdCByZXN1bHRzIHRoYXQgY29tbWFuZCBpbnRlcnJ1cHQNCj4gaXMgaWdub3JlZCBzbyBpdCBj YW4gY2F1c2UgdW5leHBlY3RlZCBvcGVyYXRpb25zLiBUaGlzIGlzIGZvdW5kZWQgYXQgc29tZQ0K PiB0b3NoaWJhIGVtbWMgd2l0aCB0aGUgYmVsbG93IHdhcm5pbmcuDQo+DQo+ICJtbWMwOiBHb3Qg Y29tbWFuZCBpbnRlcnJ1cHQgMHgwMDAwMDAwMSBldmVuIHRob3VnaA0KPiBubyBjb21tYW5kIG9w ZXJhdGlvbiB3YXMgaW4gcHJvZ3Jlc3MuIg0KPg0KPiBUaGlzIGlzc3VlIGhhcyBiZWVuIGFsc28g cmVwb3J0ZWQgYnkgWW91c3NlZiBUUklLSToNCj4gSXQgaXMgbm90IHNwZWNpZmljIHRvIFRvc2hp YmEgZGV2aWNlcywgYW5kIGhhcHBlbnMgd2l0aCBlTU1DIGRldmljZXMNCj4gYXMgd2VsbCBhcyBT RCBjYXJkIHdoaWNoIHN1cHBvcnQgQXV0by1DTUQxMiByYXRoZXIgdGhhbiBDTUQyMy4NCj4NCj4g QWxzbywgc2ltaWxhciBwYXRjaCBpcyBzdWJtaXR0ZWQgYnk6DQo+IEd3ZW5kYWwgR3JpZ25vdSA8 Z3dlbmRhbEBjaHJvbWl1bS5vcmc+DQo+DQo+IENoYW5nZXMgc2luY2UgdjE6DQo+ICBGaXhlZCBj b25mbGljdCB3aXRoIHRoZSBuZXh0IG9mIGdpdC5saW5hcm8ub3JnL3Blb3BsZS91bGYuaGFuc3Nv bi9tbWMuZ2l0DQo+ICBhbmQgVGVzdGVkIGlmIGlzc3VlIGlzIGZpeGVkIGFnYWluLg0KPg0KPiBT aWduZWQtb2ZmLWJ5OiBIYW5reXVuZyBZdSA8aGFua3l1bmcueXVAbGdlLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogQ2hhbmhvIE1pbiA8Y2hhbmhvLm1pbkBsZ2UuY29tPg0KPiBUZXN0ZWQtYnk6IFlv dXNzZWYgVFJJS0kgPHlvdXNzZWYudHJpa2lAc3QuY29tPg0KDQpCZXN0IFJlZ2FyZHMsDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpIaXNh bmFvIEtpbmthd2EgICAgICBbaGlzYW5hby5raW5rYXdhQHRvc2hpYmEuY28uanAgPG1haWx0bzpo aXNhbmFvLmtpbmthd2FAdG9zaGliYS5jby5qcD5dDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQoNCg0KKDIwMTQvMDkvMTUgMjA6MjkpLCBK ZWFuLU1pY2hlbCBIYXV0Ym9pcyB3cm90ZToNCj4gMjAxNC0wOS0xNSAxMjo1MyBHTVQrMDI6MDAg SmVhbi1NaWNoZWwgSGF1dGJvaXMNCj4gPGplYW4tbWljaGVsLmhhdXRib2lzQHZvZGFseXMuY29t PjoNCj4+IDIwMTQtMDktMTUgMTI6NDQgR01UKzAyOjAwIEphZWhvb24gQ2h1bmcgPGpoODAuY2h1 bmdAc2Ftc3VuZy5jb20+Og0KPj4+IE9uIDA5LzE1LzIwMTQgMDc6MDggUE0sIEplYW4tTWljaGVs IEhhdXRib2lzIHdyb3RlOg0KPj4+PiBIaSBKYWVob29uLA0KPj4+Pg0KPj4+Pj4gT24gMDkvMDkv MjAxNCAwOToyNiBQTSwgSmVhbi1NaWNoZWwgSGF1dGJvaXMgd3JvdGU6DQo+Pj4+Pj4gVGVzdGVk IG9uIGEgaS5NWDYgYm9hcmQsIHdpdGggU2FuZGlzayBTRElONUQxLTJHLg0KPj4+Pj4+IFdpdGhv dXQgdGhpcyBwYXRjaCwgSS9PIGVycm9ycyBvY2N1ci4NCj4+Pj4+PiBUaGlzIGVNTUMgc2VlbXMg dG8gaGF2ZSBhIGRpZmZlcmVudCBNYW51ZmFjdHVyZXIgSUQgYXMgaXQgcmVhZHMgMHg0NQ0KPj4+ Pj4+IGFuZCBub3QgMHgyIGFzIHNwZWNpZmllZCBpbiBkYXRhc2hlZXQuDQo+Pj4+PiBJIHRoaW5r IHRoaXMgcGF0Y2ggZG9uJ3QgbWVyZ2UgaW50byBtYWlubGluZS4NCj4+Pj4+IFRoaXMgaXMgbm90 IHNvbHV0aW9uIGZvciBwcm9ibGVtLg0KPj4+Pj4geW91IG1lbnRpb25lZCB0aGUgYmVsb3cgY29t bWVudCwgdGhpcyBpcyB3b3JrYXJvdW5kLg0KPj4+PiBZZXMNCj4+Pj4NCj4+Pj4+PiBTaWduZWQt b2ZmLWJ5OiBKZWFuLU1pY2hlbCBIYXV0Ym9pcyA8amVhbi1taWNoZWwuaGF1dGJvaXNAdm9kYWx5 cy5jb20+DQo+Pj4+Pj4gLS0tDQo+Pj4+Pj4gICBkcml2ZXJzL21tYy9jb3JlL21tY19vcHMuYyB8 IDkgKysrKysrKysrDQo+Pj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspDQo+ Pj4+Pj4NCj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tbWMvY29yZS9tbWNfb3BzLmMgYi9k cml2ZXJzL21tYy9jb3JlL21tY19vcHMuYw0KPj4+Pj4+IGluZGV4IGY1MWI1YmEuLjkxYmFiYWEg MTAwNjQ0DQo+Pj4+Pj4gLS0tIGEvZHJpdmVycy9tbWMvY29yZS9tbWNfb3BzLmMNCj4+Pj4+PiAr KysgYi9kcml2ZXJzL21tYy9jb3JlL21tY19vcHMuYw0KPj4+Pj4+IEBAIC00NTgsNiArNDU4LDE1 IEBAIGludCBfX21tY19zd2l0Y2goc3RydWN0IG1tY19jYXJkICpjYXJkLCB1OCBzZXQsIHU4IGlu ZGV4LCB1OCB2YWx1ZSwNCj4+Pj4+PiAgICAgICAgaWYgKCF1c2VfYnVzeV9zaWduYWwpDQo+Pj4+ Pj4gICAgICAgICAgICAgICAgcmV0dXJuIDA7DQo+Pj4+Pj4NCj4+Pj4+PiArICAgICAvKiBXT1JL QVJPVU5EOiBmb3IgU2FuZGlzayBlTU1DIGNhcmRzLCBpdCBtaWdodCBuZWVkIGNlcnRhaW4gZGVs YXkNCj4+Pj4+PiArICAgICAgKiBiZWZvcmUgc2VuZGluZyBDTUQxMyBhZnRlciBDTUQ2DQo+Pj4+ Pj4gKyAgICAgICogT24gU0RJTjVEMS0yRyBNQU5GSUQgaXMgMHg0NSBhbmQgbm90IDB4MiBhcyBz cGVjaWZpZWQgaW4gZGF0YXNoZWV0DQo+Pj4+Pj4gKyAgICAgICovDQo+Pj4+Pj4gKyAgICAgaWYg KGNhcmQtPmNpZC5tYW5maWQgPT0gQ0lEX01BTkZJRF9TQU5ESVNLIHx8DQo+Pj4+Pj4gKyAgICAg ICAgICAgICBjYXJkLT5jaWQubWFuZmlkID09IDB4NDUpIHsNCj4+Pj4+PiArICAgICAgICAgICAg IG1zbGVlcCgxKTsNCj4+Pj4+PiArICAgICB9DQo+Pj4+PiBJZiBpdCdzIGEgZ2VuZXJhbCBwcm9i bGVtIG9mIFNhbmRpc2sgU0RJTjVEMS0yRywNCj4+Pj4+IEkgdGhpbmsgeW91IG5lZWQgdG8gdmVy aWZ5IHRoaXMgcHJvYmxlbS4gQW5kIGNhbiB5b3UgdXNlIHRoZSBNTUNfRklYVVAoKSBhbmQgUVVJ Uks/DQo+Pj4+IFdlbGwsIHRoaXMgaXMgZGlmZmljdWx0IHRvIHZlcmlmeSwgSSBrbm93IHRoYXQg b24gYWxsIG15IFNESU41RDEtMkcgSQ0KPj4+PiBoYXZlIHRoaXMgTUFORklEIGRpZmZlcmVudCBm cm9tIHdoYXQgaXMgZGVmaW5lZCBieSBDSURfTUFORklEX1NBTkRJU0suDQo+Pj4+IEhvdyBzaG91 bGQgSSB1c2UgTU1DX0ZJWFVQID8gTGlrZSB0aGlzID8NCj4+PiBJIHRoaW5rIHlvdSBuZWVkIHRv IGV4cGxhaW4gd2h5IGRlbGF5IGlzIG5lZWQuDQo+Pj4gaSBkaWRuJ3QgaGF2ZSBzYW1lIGNhcmQs IGJ1dCBpdCBtaWdodCBiZSB5b3VyIGhvc3QgY29udHJvbGxlciBvciBvdGhlciBwcm9ibGVtLg0K Pj4gV2VsbCwgSSBkb24ndCBrbm93IHdoeSBpdCBpcyBuZWVkZWQsIHRoaXMgaXMgdW5kb2N1bWVu dGVkLCBub3RoaW5nIGluDQo+PiBkYXRhc2hlZXQgZXhwbGFpbnMgYW55dGhpbmcgYWJvdXQgdGhp cy4NCj4gSXQgc2VlbXMgdG8gYmUgdVNESEMgLyBERFIgbW9kZSByZWxhdGVkLiBJIGRvbid0IGV2 ZW4ga25vdyBpZiB0aGlzIGlzDQo+IGxpbWl0ZWQgdG8gU2FuZGlzayAhDQo+IEFuZCBJIGRvbid0 IGhhdmUgYW5vdGhlciBib2FyZCB3aXRoIGFub3RoZXIgbWFudWZhY3R1cmVyIGVNTUMgdG8gdGVz dC4NCj4gTWF5YmUgc29tZSBndXlzIGZyb20gRnJlZXNjYWxlIGNvdWxkIGhlbHAgd2l0aCB0aGlz ID8NCj4NCj4gVGhhbmtzLA0KPiBKTQ0KPiAtLQ0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMg bGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtbW1jIiBpbg0KPiB0aGUgYm9k eSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZw0KPiBNb3JlIG1ham9y ZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwN Cj4gLg0KPg0KDQo=