From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbaIPHoj (ORCPT ); Tue, 16 Sep 2014 03:44:39 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:36786 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbaIPHoh (ORCPT ); Tue, 16 Sep 2014 03:44:37 -0400 Message-ID: <5417EA5C.3090405@mev.co.uk> Date: Tue, 16 Sep 2014 08:44:28 +0100 From: Ian Abbott Organization: MEV Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Hartley Sweeten , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 00/11] staging: comedi: move comedi_fc functionality into core References: <1410785167-28506-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MEVEXCHANGE.mev.local (10.0.0.4) To MEVEXCHANGE.mev.local (10.0.0.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/14 19:21, Hartley Sweeten wrote: > On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote: >> The "comedi_fc" module contains a few functions for use by several >> low-level comedi drivers. Since they are used by quite a few drivers, >> it seems useful to migrate their functionality to the core "comedi" >> module, renaming them in the process, while keeping the original >> function names in "drivers/comedi_fc.h" available for now. This set of >> patches accomplishes that. >> >> The next stages after this will be to migrate the remaining inline >> functions from "drivers/comedi_fc.h" (possibly making them externally >> exported functions, although they are rather short), and then to update >> the low-level drivers to call the functions with the new names, >> eliminating the need to include "comedi_fc.h". Then >> "drivers/comedi_fc.h" can be removed as well. >> >> Note that PATCH 10 has a couple of checkpatch warnings due to >> changing an existing block comment in non-standard block-comment style. >> >> PATCH 11 has a checkpatch warning to check whether MAINTAINERS needs >> updating. It doesn't. >> >> PATCH 11 might conflict with some other patch series that haven't been >> committed yet. >> >> 01) staging: comedi: add comedi_bytes_per_scan() >> 02) staging: comedi: comedi_fc: use comedi_bytes_per_scan() >> 03) staging: comedi: add comedi_inc_scan_progress() >> 04) staging: comedi: comedi_fc: use comedi_inc_scan_progress() >> 05) staging: comedi: add comedi_handle_events() >> 06) staging: comedi: comedi_fc: cfc_write_array_to_buffer() data is >> const >> 07) staging: comedi: add comedi_write_array_to_buffer() >> 08) staging: comedi: comedi_fc.h: use comedi_write_array_to_buffer() >> 09) staging: comedi: add comedi_read_array_from_buffer() >> 10) staging: comedi: migrate copyrights from "comedi_fc.c" >> 11) staging: comedi: remove comedi_fc module >> >> drivers/staging/comedi/Kconfig | 31 ------- >> drivers/staging/comedi/comedi_buf.c | 66 +++++++++++++++ >> drivers/staging/comedi/comedidev.h | 11 +++ >> drivers/staging/comedi/drivers.c | 95 +++++++++++++++++++++ >> drivers/staging/comedi/drivers/Makefile | 1 - >> drivers/staging/comedi/drivers/comedi_fc.c | 132 ----------------------------- >> drivers/staging/comedi/drivers/comedi_fc.h | 40 ++++++--- >> 7 files changed, 201 insertions(+), 175 deletions(-) > > Ian, > > Other than I think the comedi_fc.c functions should be migrated to > comedi_buf.c instead of drivers.c I have not problems with this. I think it's debatable. The only one of the three functions you mentioned that touches the buffer is comedi_inc_scan_progress(), and I'd rather keep that with comedi_bytes_per_scan(). > And, patch 11 does have a conflict with your "... use dma_alloc_coherent..." > patches. Yes, I'll have to fix up one or the other, depending which gets applied first (unless git can magically sort it out with a three way merge). > But, > > Reviewed-by: H Hartley Sweeten > Thanks! -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C85351C2262 for ; Tue, 16 Sep 2014 07:44:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C41A0A1D08 for ; Tue, 16 Sep 2014 07:44:39 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EQjwyu3vBarw for ; Tue, 16 Sep 2014 07:44:38 +0000 (UTC) Received: from mail.mev.co.uk (mail.mev.co.uk [62.49.15.74]) by fraxinus.osuosl.org (Postfix) with ESMTP id 32D85A1D04 for ; Tue, 16 Sep 2014 07:44:38 +0000 (UTC) Message-ID: <5417EA5C.3090405@mev.co.uk> Date: Tue, 16 Sep 2014 08:44:28 +0100 From: Ian Abbott MIME-Version: 1.0 Subject: Re: [PATCH 00/11] staging: comedi: move comedi_fc functionality into core References: <1410785167-28506-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Hartley Sweeten , "driverdev-devel@linuxdriverproject.org" Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" On 15/09/14 19:21, Hartley Sweeten wrote: > On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote: >> The "comedi_fc" module contains a few functions for use by several >> low-level comedi drivers. Since they are used by quite a few drivers, >> it seems useful to migrate their functionality to the core "comedi" >> module, renaming them in the process, while keeping the original >> function names in "drivers/comedi_fc.h" available for now. This set of >> patches accomplishes that. >> >> The next stages after this will be to migrate the remaining inline >> functions from "drivers/comedi_fc.h" (possibly making them externally >> exported functions, although they are rather short), and then to update >> the low-level drivers to call the functions with the new names, >> eliminating the need to include "comedi_fc.h". Then >> "drivers/comedi_fc.h" can be removed as well. >> >> Note that PATCH 10 has a couple of checkpatch warnings due to >> changing an existing block comment in non-standard block-comment style. >> >> PATCH 11 has a checkpatch warning to check whether MAINTAINERS needs >> updating. It doesn't. >> >> PATCH 11 might conflict with some other patch series that haven't been >> committed yet. >> >> 01) staging: comedi: add comedi_bytes_per_scan() >> 02) staging: comedi: comedi_fc: use comedi_bytes_per_scan() >> 03) staging: comedi: add comedi_inc_scan_progress() >> 04) staging: comedi: comedi_fc: use comedi_inc_scan_progress() >> 05) staging: comedi: add comedi_handle_events() >> 06) staging: comedi: comedi_fc: cfc_write_array_to_buffer() data is >> const >> 07) staging: comedi: add comedi_write_array_to_buffer() >> 08) staging: comedi: comedi_fc.h: use comedi_write_array_to_buffer() >> 09) staging: comedi: add comedi_read_array_from_buffer() >> 10) staging: comedi: migrate copyrights from "comedi_fc.c" >> 11) staging: comedi: remove comedi_fc module >> >> drivers/staging/comedi/Kconfig | 31 ------- >> drivers/staging/comedi/comedi_buf.c | 66 +++++++++++++++ >> drivers/staging/comedi/comedidev.h | 11 +++ >> drivers/staging/comedi/drivers.c | 95 +++++++++++++++++++++ >> drivers/staging/comedi/drivers/Makefile | 1 - >> drivers/staging/comedi/drivers/comedi_fc.c | 132 ----------------------------- >> drivers/staging/comedi/drivers/comedi_fc.h | 40 ++++++--- >> 7 files changed, 201 insertions(+), 175 deletions(-) > > Ian, > > Other than I think the comedi_fc.c functions should be migrated to > comedi_buf.c instead of drivers.c I have not problems with this. I think it's debatable. The only one of the three functions you mentioned that touches the buffer is comedi_inc_scan_progress(), and I'd rather keep that with comedi_bytes_per_scan(). > And, patch 11 does have a conflict with your "... use dma_alloc_coherent..." > patches. Yes, I'll have to fix up one or the other, depending which gets applied first (unless git can magically sort it out with a three way merge). > But, > > Reviewed-by: H Hartley Sweeten > Thanks! -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel