From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTnRX-00010a-SA
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 03:45:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTnRO-00009Y-QS
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 03:44:55 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:39576)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTnRO-00009J-JZ
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 03:44:46 -0400
Received: by mail-wg0-f52.google.com with SMTP id x13so5094629wgg.35
	for <qemu-devel@nongnu.org>; Tue, 16 Sep 2014 00:44:42 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5417EA66.6040807@redhat.com>
Date: Tue, 16 Sep 2014 09:44:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410582855-21870-1-git-send-email-jsnow@redhat.com>	<1410582855-21870-4-git-send-email-jsnow@redhat.com>	<541445F8.7080909@redhat.com>
	<54149FF3.2080301@redhat.com> <5417146E.5090603@redhat.com>
In-Reply-To: <5417146E.5090603@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 03/10] AHCI: Add PRD interrupt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, mst@redhat.com

Il 15/09/2014 18:31, John Snow ha scritto:
> 
> 
> On 09/13/2014 03:50 PM, Paolo Bonzini wrote:
>> Il 13/09/2014 15:26, Paolo Bonzini ha scritto:
>>>>>
>>>>> +    if (ad->dp_intr_req) {
>>>>> +        ahci_trigger_irq(ad->hba, ad, PORT_IRQ_SG_DONE);
>>>>> +        ad->dp_intr_req = 0;
>>>>> +    }
>>> Is it also needed in the error case?  Especially the short-PRDT case
>>> that you are adding in the next patch.
>>>
>>
>> ... and is it also needed for NCQ, albeit with a separate flag?
>>
>> Paolo
>>
> 
> I had actually thought that it wasn't; due to the more asynchronous
> nature of NCQ. But... looking back at the specification, I can't find
> anywhere that explicitly says you can't use these bits for NCQ.

I suggest that you leave out this bit for a moment, so that we can get
Windows fixed.

Paolo