From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] clang: sizeof(type) must not have __attribute__(aligned) Date: Tue, 16 Sep 2014 11:26:04 -0700 Message-ID: <541880BC.8010201@linaro.org> References: <533464AA.8080807@linaro.org> <1410633772-23044-1-git-send-email-saper@saper.info> <1410884486.23505.1.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XTxS6-0002aE-54 for xen-devel@lists.xenproject.org; Tue, 16 Sep 2014 18:26:10 +0000 Received: by mail-pa0-f50.google.com with SMTP id bj1so318789pad.37 for ; Tue, 16 Sep 2014 11:26:06 -0700 (PDT) In-Reply-To: <1410884486.23505.1.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Marcin Cieslak Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 16/09/14 09:21, Ian Campbell wrote: > On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote: > > The commit message could go into a bit more detail as to why this is not > allowed. To me it sounds like clang is being overly picky, surely it can > just ignore the alignment in that context? Clang will throw a warning when an attribute is unused (see -Wignored-attributes). In case of libxc, we compiled with -Werror which will turn this warning into an error. I sent a patch few months ago [1] to disable this option. One of the solution was to modify mkheader.py. Regards, -- Julien Grall