From mboxrd@z Thu Jan 1 00:00:00 1970 From: riel@surriel.com (Rik van Riel) Date: Tue, 16 Sep 2014 14:44:46 -0400 Subject: Checkpatch Patches In-Reply-To: References: <541830AB.6020104@gmail.com> <41030.1410877181@turing-police.cc.vt.edu> <54187326.2090200@surriel.com> <11625.1410889166@turing-police.cc.vt.edu> Message-ID: <5418851E.3040104@surriel.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/16/2014 02:36 PM, Kristofer Hallin wrote: > On Tue, Sep 16, 2014 at 8:29 PM, Nick Krause > wrote: >> On Tue, Sep 16, 2014 at 1:39 PM, >> wrote: >>> On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said: >>>> -----BEGIN PGP SIGNED MESSAGE----- >>> >>>> On 09/16/2014 01:12 PM, Nick Krause wrote: >>>> >>>>> I am going to resend my patch and see if it's good and if >>>>> not I am going to leave for a while. >>>> >>>> You may want to consider fixing them, by applying the advice >>>> provided by many people, before resending them. >>> >>> That's just crazy talk. >> >> I am fixing them first and them sending them out. I am going to >> listen now and only do them correctly. Nick > > No, you won't. Nick, this is a chance for you to prove the nay-sayers wrong (or right). When re-posting your patch, you can include information on what tips you got on how to improve the patch, and how you applied that information in the new version of the patch. This is a good idea for anybody resubmitting a changed patch, because it tells other reviewers what changes were made, why, and who pointed out the idea for the change. - -- All rights reversed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUGIUeAAoJEM553pKExN6DEt8H/36FILPmG4wOK3TZFpQEVJHv Lxq4DLq7GBUS37PhL/wjdYnLD4RJmOhpGk+FlZBhJ0StnCvS38Su7wwyZTzgCPIS ir3EYOKhiFgEEuoB4iVaDc2FNv9jKKRVy/QK3jwkdt5oTBvr/I6YZzj2XAFJaUp9 0/RvdSNZU6kcvhTkd5xdDaaX1iOpxrggccRl+Pv2GBapeIEKvO6zk9U2GuLw+r6q OLfJ5BElpEReoqFJNUXxzT+UyTmMel21REdfyu9UxAEONrQ2A3UHx/7upy71YpyR a/IADIuBSXTdb31b+uuoFPfSUp4cs7WMyIDK2/tlL8wF28GLoL39X2xhWE3gkUU= =7mL1 -----END PGP SIGNATURE-----