From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] clang: sizeof(type) must not have __attribute__(aligned) Date: Wed, 17 Sep 2014 11:50:11 +0100 Message-ID: <541983830200007800035A1D@mail.emea.novell.com> References: <533464AA.8080807@linaro.org> <1410633772-23044-1-git-send-email-saper@saper.info> <1410884486.23505.1.camel@citrix.com> <541880BC.8010201@linaro.org> <1410892339.23505.22.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XUCoP-0005Ap-R1 for xen-devel@lists.xenproject.org; Wed, 17 Sep 2014 10:50:13 +0000 In-Reply-To: <1410892339.23505.22.camel@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, Marcin Cieslak List-Id: xen-devel@lists.xenproject.org >>> On 16.09.14 at 20:32, wrote: > On Tue, 2014-09-16 at 11:26 -0700, Julien Grall wrote: >> Hi Ian, >> >> On 16/09/14 09:21, Ian Campbell wrote: >> > On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote: >> > >> > The commit message could go into a bit more detail as to why this is not >> > allowed. To me it sounds like clang is being overly picky, surely it can >> > just ignore the alignment in that context? >> >> Clang will throw a warning when an attribute is unused (see >> -Wignored-attributes). In case of libxc, we compiled with -Werror which >> will turn this warning into an error. > > Sounds to me like -Wignored-attributes is a bit pointless, perhaps we > shouldn't use it? +1 Jan