From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] clang: sizeof(type) must not have
	__attribute__(aligned)
Date: Wed, 17 Sep 2014 14:18:53 -0700
Message-ID: <5419FABD.5050103@linaro.org>
References: <533464AA.8080807@linaro.org>
	<1410633772-23044-1-git-send-email-saper@saper.info>
	<1410884486.23505.1.camel@citrix.com> <541880BC.8010201@linaro.org>
	<1410892339.23505.22.camel@citrix.com>
	<541983830200007800035A1D@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1XUMcs-0000A2-QQ
	for xen-devel@lists.xenproject.org; Wed, 17 Sep 2014 21:18:58 +0000
Received: by mail-pd0-f172.google.com with SMTP id v10so2869024pde.17
	for <xen-devel@lists.xenproject.org>;
	Wed, 17 Sep 2014 14:18:55 -0700 (PDT)
In-Reply-To: <541983830200007800035A1D@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Ian Campbell <ian.campbell@citrix.com>, Marcin Cieslak <saper@saper.info>
List-Id: xen-devel@lists.xenproject.org

Hi,

On 17/09/14 03:50, Jan Beulich wrote:
>>>> On 16.09.14 at 20:32, <ian.campbell@citrix.com> wrote:
>> On Tue, 2014-09-16 at 11:26 -0700, Julien Grall wrote:
>>> Hi Ian,
>>>
>>> On 16/09/14 09:21, Ian Campbell wrote:
>>>> On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote:
>>>>
>>>> The commit message could go into a bit more detail as to why this is not
>>>> allowed. To me it sounds like clang is being overly picky, surely it can
>>>> just ignore the alignment in that context?
>>>
>>> Clang will throw a warning when an attribute is unused (see
>>> -Wignored-attributes). In case of libxc, we compiled with -Werror which
>>> will turn this warning into an error.
>>
>> Sounds to me like -Wignored-attributes is a bit pointless, perhaps we
>> shouldn't use it?
>
> +1

Ian, shall I resend the patch which disabled this attribute?

https://patches.linaro.org/27062/

Regards,

-- 
Julien Grall