From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUOV4-0004EK-D7 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 19:19:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUOUz-0004Nf-Uv for qemu-devel@nongnu.org; Wed, 17 Sep 2014 19:19:02 -0400 Message-ID: <541A0AC3.6070600@redhat.com> Date: Wed, 17 Sep 2014 16:27:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410989576-9311-1-git-send-email-mdroth@linux.vnet.ibm.com> <1410989576-9311-3-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1410989576-9311-3-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i1hpoPs6HgGptGK6KH8El8LABkn15OKln" Subject: Re: [Qemu-devel] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i1hpoPs6HgGptGK6KH8El8LABkn15OKln Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2014 03:32 PM, Michael Roth wrote: > If the .data field of a QAPI Union is NULL, we don't need to free > any of the union fields. >=20 > Make use of the new visit_start_union interface to access this > information and instruct the generated code to not visit these > fields when this occurs. >=20 > Cc: qemu-stable@nongnu.org > Reported-by: Fam Zheng > Suggested-by: Paolo Bonzini > Reviewed-by: Paolo Bonzini > Signed-off-by: Michael Roth > --- > qapi/qapi-dealloc-visitor.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 The comment helps. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i1hpoPs6HgGptGK6KH8El8LABkn15OKln Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUGgrDAAoJEKeha0olJ0NqfFYH/RrGREDmp/pFkNS6QqU0qyk6 1xraG+3bh34DQhMEJlL6R8pc+QbjqBks5UBdbbMgInKZbf0hiwtazQyUjrkwtZKg GdgXsVaKLrHcA/pleYP/GVdD1brBzJltr26J61mXvu02kB6WXcNtO/AiQC2Yt34j MrLoda3EhVbTSS0QWKYXSn47ORmknZjF0DdCvMEo+5fPkaM0Xp8g1vCjLyfh6jK/ 5m+gr4APD86Fm/3+COluqyQLRJkyysPge26gXf8F/Fuo1O9rzVOxwBvqNLiyxq91 BAntzqACjnMycCpBTFd95znZK4+U/oTcy79137Yb5pOqcw3bVSYOGFd4KlrVt6k= =elzP -----END PGP SIGNATURE----- --i1hpoPs6HgGptGK6KH8El8LABkn15OKln--