From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] gpio: samsung: Remove remaining check for CONFIG_S5P_GPIO_DRVSTR Date: Thu, 18 Sep 2014 21:34:27 +0200 Message-ID: <541B33C3.2080102@gmail.com> References: <1404496099-26708-1-git-send-email-t.figa@samsung.com> <53C67783.4090407@samsung.com> <1409825317.5546.94.camel@x220> <201409041803.46098.arnd@arndb.de> <1411030649.2017.7.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f181.google.com ([74.125.82.181]:46672 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820AbaIRTeb (ORCPT ); Thu, 18 Sep 2014 15:34:31 -0400 In-Reply-To: <1411030649.2017.7.camel@x220> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Paul Bolle , Linus Walleij , Alexandre Courbot Cc: Arnd Bergmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Paul, On 18.09.2014 10:57, Paul Bolle wrote: > On Thu, 2014-09-04 at 18:03 +0200, Arnd Bergmann wrote: >> On Thursday 04 September 2014, Paul Bolle wrote: >>> That check for CONFIG_S5P_GPIO_DRVSTR is still present in v3.17-rc3 and >>> next-20140903. Should I submit the trivial patch to remove it (and the >>> dead code it hides)? >> >> Yes, I think this one is an obvious candidate for removal. > > Still there in v3.17-rc5 and next-20140918. So I submit yet another > trivial cleanup. > > Done on top of next-20140918. Only tested by grepping the tree. Please > note that, obviously, nothing uses s5p_gpio_get_drvstr() or > s5p_gpio_set_drvstr(). > > > Paul Bolle > -------->8-------- > From: Paul Bolle > > Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") > removed the Kconfig symbol S5P_GPIO_DRVSTR. It didn't remove one check > for the related macro. Remove that check and the dead code it hides. > > Signed-off-by: Paul Bolle Thanks for the patch. Reviewed-by: Tomasz Figa Best regards, Tomasz