All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Rostislav Lisovy <lisovy@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	sojkam1@fel.cvut.cz, michal.vokac@comap.cz,
	Rostislav Lisovy <lisovy@merica.cz>
Subject: Re: [PATCH v2] watchdog: omap_wdt: Add 'early_disable' module parameter
Date: Thu, 18 Sep 2014 21:12:28 -0700	[thread overview]
Message-ID: <541BAD2C.8080902@roeck-us.net> (raw)
In-Reply-To: <1410967369.5542.2.camel@lp-lvrv.comap.cz>

On 09/17/2014 08:22 AM, Rostislav Lisovy wrote:
> Hello Guenter;
> Thanks for the review.
>
> On Út, 2014-09-16 at 08:49 -0700, Guenter Roeck wrote:
>> How do you know that the watchdog was already running ?
>> Seems to me you are just making an assumption that it is running
>> without really knowing for sure.
>
> You are definitely right, however the OMAP Watchdog seems to be such a
> sophisticated piece of hardware that there is no possible way how to
> determine if it is running or not (sampling timer counter twice and
> comparing both values is they differ is stupid).
>
How about reading the OMAP_WATCHDOG_SPR register ?

Either case, you can not issue a message about the watchdog being
stopped or started if you don't know if it was actually stopped
or started. Also, if you don't really know if the watchdog was
stopped or started, all you can do is to either stop or start it,
without judgment about its previous condition.

Guenter


  reply	other threads:[~2014-09-19  4:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 14:20 [PATCH v2] watchdog: omap_wdt: Add 'early_disable' module parameter Rostislav Lisovy
2014-09-16 15:49 ` Guenter Roeck
2014-09-17 15:22   ` Rostislav Lisovy
2014-09-19  4:12     ` Guenter Roeck [this message]
2014-09-23 10:44       ` Rostislav Lisovy
2014-09-23 16:14         ` Guenter Roeck
2014-09-23 16:14           ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541BAD2C.8080902@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lisovy@gmail.com \
    --cc=lisovy@merica.cz \
    --cc=michal.vokac@comap.cz \
    --cc=sojkam1@fel.cvut.cz \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.