All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, luonengjun@huawei.com,
	peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing
Date: Fri, 19 Sep 2014 10:09:28 +0200	[thread overview]
Message-ID: <541BE4B8.3010609@redhat.com> (raw)
In-Reply-To: <1411097848-3900-1-git-send-email-zhang.zhanghailiang@huawei.com>

Il 19/09/2014 05:37, zhanghailiang ha scritto:
> The logic of pcmcia_socket_unregister is wrong,
> which will cause a freed memory accessing
> 
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> Hi,
> 
> The function pcmcia_socket_unregister seemes to be unused,
> Should it be removed? Thanks.

Perhaps---however, the patch silences a Coverity warning, so it is
worthwhile.  Thanks for doing this!

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

  parent reply	other threads:[~2014-09-19  8:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  3:37 [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing zhanghailiang
2014-09-19  6:54 ` Markus Armbruster
2014-09-19 14:14   ` Peter Maydell
2014-09-19  8:09 ` Paolo Bonzini [this message]
2014-09-20 13:58 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-09-22  6:23   ` Markus Armbruster
2014-09-22  7:34     ` Michael Tokarev
2014-10-23  6:33       ` Michael Tokarev
2014-10-23  6:52         ` Markus Armbruster
2014-10-23  7:16         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541BE4B8.3010609@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.