From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH V5 06/15] Add efi_arch_handle_cmdline() for
 processing commandline
Date: Mon, 22 Sep 2014 13:17:35 +0100
Message-ID: <54202F7F0200007800036E66@mail.emea.novell.com>
References: <1411080607-32365-1-git-send-email-roy.franz@linaro.org>
	<1411080607-32365-7-git-send-email-roy.franz@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411080607-32365-7-git-send-email-roy.franz@linaro.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roy Franz <roy.franz@linaro.org>
Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, fu.wei@linaro.org
List-Id: xen-devel@lists.xenproject.org

>>> On 19.09.14 at 00:49, <roy.franz@linaro.org> wrote:
> Add arch function for processing the Xen commandline and
> updating internal structures.
> 
> Signed-off-by: Roy Franz <roy.franz@linaro.org>

With two small requests for adjustments below
Acked-by: Jan Beulich <jbeulich@suse.com>

> @@ -256,7 +257,8 @@ static void __init PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode)
>  }
>  
>  static unsigned int __init get_argv(unsigned int argc, CHAR16 **argv,
> -                                    CHAR16 *cmdline, UINTN cmdsize)
> +                                    CHAR16 *cmdline, UINTN cmdsize,
> +                                    CHAR16 **options)

I think this would better be named "dom0_options" or "dom0_opts" or
some such (also in the caller).

> @@ -701,14 +701,14 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>      dir_handle = get_parent_handle(loaded_image, &file_name);
>  
>      argc = get_argv(0, NULL, loaded_image->LoadOptions,
> -                    loaded_image->LoadOptionsSize);
> +                    loaded_image->LoadOptionsSize, &options);

I don't see why you don't pass NULL here, the more that you add
a respective check to get_argv().

Jan