From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH for-4.5 v6 00/16] Xen VMware tools support Date: Mon, 22 Sep 2014 16:19:05 +0100 Message-ID: <54203DE9.9040307@eu.citrix.com> References: <1411236447-7435-1-git-send-email-dslutz@verizon.com> <1411394209.18331.113.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411394209.18331.113.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Don Slutz Cc: Tim Deegan , Kevin Tian , Keir Fraser , Jun Nakajima , Stefano Stabellini , Ian Jackson , Eddie Dong , xen-devel@lists.xen.org, Aravind Gopalakrishnan , Jan Beulich , Andrew Cooper , Boris Ostrovsky , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On 09/22/2014 02:56 PM, Ian Campbell wrote: > On Sat, 2014-09-20 at 14:07 -0400, Don Slutz wrote: > >> I picked this subset to start with because it only has changes in >> Xen. >> >> Some of this code is already in QEMU > As I suggest in my reply to one for the rpc port patches it's not clear > that any of this needs to be in Xen rather than qemu in the first place. > > I came to think this even more once I saw the save/restore support... I don't think qemu can get notified on either cpuid or #GP faults, can it? A big chunk of the functionality here is to allow a userspace process to transparently make the "hypercalls" without the OS needing to explicitly give it access to the IO space, by trapping the resulting #GP faults and checking to see if they are IO instructions . If that's functionality we think is important, then it will have to be done in Xen, I think. -George