From mboxrd@z Thu Jan  1 00:00:00 1970
From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
Subject: Re: [PATCH 47/89] drm/i915/skl: SKL Watermark
	Computation
Date: Tue, 23 Sep 2014 11:30:21 +0530
Message-ID: <54210C75.7050000@intel.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-48-git-send-email-damien.lespiau@intel.com>
 <20140917120751.GL12416@intel.com>
 <20140922223639.GA32353@strange.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id D4C8B6E213
 for <intel-gfx@lists.freedesktop.org>; Mon, 22 Sep 2014 23:01:40 -0700 (PDT)
In-Reply-To: <20140922223639.GA32353@strange.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


On Tuesday 23 September 2014 04:06 AM, Damien Lespiau wrote:
> Hi Satheesh,
>
> On Wed, Sep 17, 2014 at 03:07:51PM +0300, Ville Syrj=E4l=E4 wrote:
>>> +static bool skl_compute_plane_wm(struct skl_pipe_wm_parameters *p,
>>> +				   struct intel_plane_wm_parameters *p_params,
>>> +				   uint16_t max_page_buff_alloc,
>>> +				   uint32_t mem_value,
>>> +				   uint16_t *res_blocks, /* out */
>>> +				   uint8_t *res_lines /* out */)
>>> +{
>>> +	uint32_t method1, method2, plane_bytes_per_line;
>>> +	uint32_t result_bytes;
>>> +
>>> +	if (!p->active || !p_params->enabled) {
>>> +		*res_blocks =3D PLANE_WM_BLOCKS_DEFAULT;
>>> +		*res_lines =3D PLANE_WM_LINES_DEFAULT;
>> Why do we need to set !=3D0 values for disabled planes?
>>
>>> +		return false;
>>> +	}
> Do you remember why we would program some default numbers of blocks/lines
> for disabled planes? Can't find a reason to do so now.
Yes, that's not required as returning false here disables the WM itself.
>
> Thanks,
>