From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH V5 06/15] Add efi_arch_handle_cmdline() for
 processing commandline
Date: Tue, 23 Sep 2014 13:25:58 +0100
Message-ID: <542182F6020000780003799D@mail.emea.novell.com>
References: <1411080607-32365-1-git-send-email-roy.franz@linaro.org>
	<1411080607-32365-7-git-send-email-roy.franz@linaro.org>
	<54202F7F0200007800036E66@mail.emea.novell.com>
	<CAFECyb9CRUccOfuTMtHMYYXqpYut9+vd1MTE4v5NysnNDptkbw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFECyb9CRUccOfuTMtHMYYXqpYut9+vd1MTE4v5NysnNDptkbw@mail.gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roy Franz <roy.franz@linaro.org>
Cc: keir <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Fu Wei <fu.wei@linaro.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 23.09.14 at 03:40, <roy.franz@linaro.org> wrote:
> On Mon, Sep 22, 2014 at 5:17 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 19.09.14 at 00:49, <roy.franz@linaro.org> wrote:
>>> @@ -256,7 +257,8 @@ static void __init PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode)
>>>  }
>>>
>>>  static unsigned int __init get_argv(unsigned int argc, CHAR16 **argv,
>>> -                                    CHAR16 *cmdline, UINTN cmdsize)
>>> +                                    CHAR16 *cmdline, UINTN cmdsize,
>>> +                                    CHAR16 **options)
>>
>> I think this would better be named "dom0_options" or "dom0_opts" or
>> some such (also in the caller).
> 
> I think xen_options would be better, or else I'm really confused :)
> This string is combined with the Xen options from the
> config file into mbi.cmdline. Dom0 arguments come from the "kernel"
> line in the configuration tile.

Indeed - I mixed things up: This is the first "--" separator, the Dom0
options come after the second. In which case staying with just
"options" is quite fine.

Jan